Skip to content

feat: add hostname-suffix option to config-ssh #17270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 7, 2025
Merged

feat: add hostname-suffix option to config-ssh #17270

merged 2 commits into from
Apr 7, 2025

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Apr 7, 2025 •
edited
Loading

Adds hostname-suffix as a Config SSH option that we get from Coderd, and also accept via a CLI flag.

It doesn't actually do anything with this value --- that's for PRs up the stack, since we need the coder ssh command to be updated to understand the suffix first.

@spikecurtis spikecurtis mentioned this pull request Apr 7, 2025
Merged
@spikecurtis Graphite App
Copy link
Contributor Author

spikecurtis commented Apr 7, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@spikecurtis spikecurtis mentioned this pull request Apr 7, 2025
Merged
@spikecurtis spikecurtis force-pushed the spike/host-suffix/sdk-ssh-config branch from f8dc116 to 7814ad8 Compare April 7, 2025 06:44
@spikecurtis spikecurtis force-pushed the spike/host-suffix/config-ssh-option-only branch from 2cd5438 to 3da0c30 Compare April 7, 2025 06:44
@spikecurtis spikecurtis marked this pull request as ready for review April 7, 2025 06:45
@spikecurtis spikecurtis requested review from johnstcn and mafredri April 7, 2025 06:45
@spikecurtis spikecurtis force-pushed the spike/host-suffix/config-ssh-option-only branch from 3da0c30 to 978e9c5 Compare April 7, 2025 07:22
@spikecurtis spikecurtis force-pushed the spike/host-suffix/sdk-ssh-config branch from 7814ad8 to 51f3a38 Compare April 7, 2025 07:22
mafredri
mafredri approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the flag/env inconsistency is fixed 👍🏻

@spikecurtis spikecurtis force-pushed the spike/host-suffix/sdk-ssh-config branch 2 times, most recently from 2815bcc to ae61aee Compare April 7, 2025 07:36
@spikecurtis spikecurtis force-pushed the spike/host-suffix/config-ssh-option-only branch 2 times, most recently from b5962b8 to c010035 Compare April 7, 2025 07:42
@spikecurtis spikecurtis force-pushed the spike/host-suffix/sdk-ssh-config branch from ae61aee to 5410640 Compare April 7, 2025 07:43
@spikecurtis spikecurtis changed the base branch from spike/host-suffix/sdk-ssh-config to graphite-base/17270 April 7, 2025 07:57
@spikecurtis spikecurtis force-pushed the graphite-base/17270 branch from 5410640 to 2424873 Compare April 7, 2025 07:57
@spikecurtis spikecurtis force-pushed the spike/host-suffix/config-ssh-option-only branch from c010035 to e0c32f0 Compare April 7, 2025 07:57
@graphite-app graphite-app bot changed the base branch from graphite-base/17270 to main April 7, 2025 07:57
@spikecurtis spikecurtis force-pushed the spike/host-suffix/config-ssh-option-only branch from e0c32f0 to 632adc9 Compare April 7, 2025 07:57
@spikecurtis spikecurtis merged commit 59c5bc9 into main Apr 7, 2025
37 checks passed
@spikecurtis Graphite App
Copy link
Contributor Author

Merge activity

  • Apr 7, 4:11 AM EDT: A user merged this pull request with Graphite.

@spikecurtis spikecurtis deleted the spike/host-suffix/config-ssh-option-only branch April 7, 2025 08:11
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

@johnstcn johnstcn johnstcn approved these changes

Assignees

@spikecurtis spikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spikecurtis @mafredri @johnstcn