Skip to content

feat: add host suffix to /api/v2/deployment/ssh #17269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2025
Merged

feat: add host suffix to /api/v2/deployment/ssh #17269

merged 1 commit into from
Apr 7, 2025
+27 −6

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Apr 7, 2025 •
edited
Loading

Adds HostnameSuffix to ssh config API and deprecates HostnamePrefix. We will still support setting and using the prefix for some time.

@spikecurtis Graphite App
Copy link
Contributor Author

spikecurtis commented Apr 7, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@spikecurtis spikecurtis mentioned this pull request Apr 7, 2025
Merged
@spikecurtis spikecurtis mentioned this pull request Apr 7, 2025
Merged
@spikecurtis spikecurtis marked this pull request as ready for review April 7, 2025 06:33
@spikecurtis spikecurtis force-pushed the spike/host-suffix/sdk-ssh-config branch from f8dc116 to 7814ad8 Compare April 7, 2025 06:44
@spikecurtis spikecurtis requested review from johnstcn and mafredri April 7, 2025 06:45
@spikecurtis spikecurtis force-pushed the spike/host-suffix/sdk-ssh-config branch from 7814ad8 to 51f3a38 Compare April 7, 2025 07:22
@spikecurtis spikecurtis changed the base branch from spike/host-suffix/deployment-option to graphite-base/17269 April 7, 2025 07:35
@spikecurtis spikecurtis force-pushed the spike/host-suffix/sdk-ssh-config branch from 51f3a38 to 2815bcc Compare April 7, 2025 07:36
@spikecurtis spikecurtis force-pushed the graphite-base/17269 branch from ef272ce to 87d9ff0 Compare April 7, 2025 07:36
@graphite-app graphite-app bot changed the base branch from graphite-base/17269 to main April 7, 2025 07:36
@spikecurtis spikecurtis force-pushed the spike/host-suffix/sdk-ssh-config branch from 2815bcc to ae61aee Compare April 7, 2025 07:36
@spikecurtis spikecurtis force-pushed the spike/host-suffix/sdk-ssh-config branch from ae61aee to 5410640 Compare April 7, 2025 07:43
@spikecurtis spikecurtis merged commit 2424873 into main Apr 7, 2025
38 of 40 checks passed
@spikecurtis Graphite App
Copy link
Contributor Author

Merge activity

  • Apr 7, 3:57 AM EDT: A user merged this pull request with Graphite.

@spikecurtis spikecurtis deleted the spike/host-suffix/sdk-ssh-config branch April 7, 2025 07:57
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2025
johnstcn
johnstcn reviewed Apr 7, 2025
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

post-merge approval 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn left review comments

@mafredri mafredri mafredri approved these changes

Assignees

@spikecurtis spikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spikecurtis @mafredri @johnstcn