feat: add coder connect exists hidden subcommand #17418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ecef684 to
169ab02
Compare
mafredri
approved these changes
Apr 16, 2025
| @@ -175,6 +181,10 @@ func (r *RootCmd) RunWithSubcommands(subcommands []*serpent.Command) { | |||
| //nolint:revive,gocritic | |||
| os.Exit(code) | |||
| } | |||
| if errors.Is(err, ErrSilent) { | |||
There was a problem hiding this comment.
&exitError{code: 1} could potentially be used instead, but I see other uses of it have disappeared from the code base.
ethanndickson
approved these changes
Apr 17, 2025
169ab02 to
a89e1c3
Compare
a89e1c3 to
dc5fab3
Compare
Merge activity
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new hidden subcommand
coder connect exists <hostname>that checks if the name exists via Coder Connect. This will be used in SSH config to match only if Coder Connect is unavailable for the hostname in question, so that the SSH client will directly dial the workspace over an existing Coder Connect tunnel.Also refactors the way we inject a test DNS resolver into the lookup functions so that we can test from outside the
workspacesdkpackage.