-
Notifications
You must be signed in to change notification settings - Fork 874
feat: modify config-ssh to check for Coder Connect #17419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
efdb86b
to
3073db4
Compare
ecef684
to
169ab02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Tried it out and seems to work well. This also (perhaps inadvertently) fixes most issues when trying to connect to stopped workspaces as it will automatically proxy the first time and trigger autostart. 😄
Edit: Just realized that setting
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after the -o
settings are added to the non-proxycommand.
It'd be nice to have two entries in the SSH config, i.e:
Host *.coder Foo=Bar Match host *.coder !exec "/Users/maf/Code/coder/coder connect exists %h" ...
It's confusing that this works, I thought the rule was whatever Host appeared first in the config was used, so that this would never hit the match block. Apparently not.
This also (perhaps inadvertently) fixes most issues when trying to connect to stopped workspaces as it will automatically proxy the first time and trigger autostart.
This is sick
169ab02
to
a89e1c3
Compare
3073db4
to
2bb6713
Compare
a89e1c3
to
dc5fab3
Compare
2bb6713
to
afbcc03
Compare
afbcc03
to
a8cf4c3
Compare
dc5fab3
to
3b54254
Compare
a8cf4c3
to
c4e9eeb
Compare
Ok, now looks like
|
c4e9eeb
to
77364ba
Compare
Merge activity
|
@spikecurtis works as expected now, thanks! It'd be nice to move those default ones (at least ConnectTimeout, StrictHostKeyChecking, and UserKnownHostsFile, but probably LogLevel too) to the match block though, since host key verification works well over Coder Connect (seems a shame to disable it) and the others are most likely related to proxying as well. |
Honestly, we can probably retire |
Oh yeah, I thought it was still a requirement for the proxy command but it seems you are right, we can totally do that! I think the |
relates to #16828
Changes SSH config so that suffixes only match if Coder Connect is not running / available. This means that we will use the existing Coder Connect tunnel if it is available, rather than creating a new tunnel via
coder ssh --stdio
.