Skip to content

chore: change config-ssh Call to Action to use suffix #17445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Apr 17, 2025

fixes #16828

With all the recent changes, I believe it is now safe to change the Call to Action for config-ssh to use the hostname suffix rather than prefix if it was set.

Copy link
Contributor Author

spikecurtis commented Apr 17, 2025

@spikecurtis spikecurtis requested a review from mafredri April 17, 2025 07:57
@spikecurtis spikecurtis marked this pull request as ready for review April 17, 2025 07:58
@spikecurtis spikecurtis force-pushed the spike/host-suffix/config-ssh-cta branch from 3a4bb37 to b347e07 Compare April 17, 2025 07:59
@spikecurtis spikecurtis changed the base branch from spike/config-ssh-match-suffix to graphite-base/17445 April 17, 2025 08:03
@spikecurtis spikecurtis force-pushed the graphite-base/17445 branch from 77364ba to b0854aa Compare April 17, 2025 08:04
@spikecurtis spikecurtis force-pushed the spike/host-suffix/config-ssh-cta branch from b347e07 to 20fa65c Compare April 17, 2025 08:04
@graphite-app graphite-app bot changed the base branch from graphite-base/17445 to main April 17, 2025 08:04
@spikecurtis spikecurtis force-pushed the spike/host-suffix/config-ssh-cta branch from 20fa65c to a072079 Compare April 17, 2025 08:04
@spikecurtis spikecurtis merged commit 9fe3fd4 into main Apr 17, 2025
35 checks passed
Copy link
Contributor Author

Merge activity

  • Apr 17, 4:16 AM EDT: A user merged this pull request with Graphite.

@spikecurtis spikecurtis deleted the spike/host-suffix/config-ssh-cta branch April 17, 2025 08:16
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor SSH prefix into a workspace suffix
2 participants