Skip to content

fix: disable AccountForm when user is not allowed edit users #3649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 23, 2022
Merged

fix: disable AccountForm when user is not allowed edit users #3649

merged 7 commits into from
Aug 23, 2022

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Aug 23, 2022 •
edited
Loading

Fixes #3286

@johnstcn johnstcn force-pushed the cj/gh-3286/update-usernames branch from 92eb342 to 8772cf0 Compare August 23, 2022 19:21
@johnstcn johnstcn marked this pull request as ready for review August 23, 2022 19:34
@johnstcn johnstcn requested a review from a team as a code owner August 23, 2022 19:34
@johnstcn johnstcn requested review from jsjoeio and removed request for a team August 23, 2022 19:34
Emyrk
Emyrk approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to disable the update settings button 👍

jsjoeio
jsjoeio approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking fabulous!

johnstcn and others added 3 commits August 23, 2022 20:43
@johnstcn @jsjoeio
PR comment
8e8b4ec 
Co-authored-by: Joe Previte <jjprevite@gmail.com>
@johnstcn
ensure button is also not enabled
a8ad515
@johnstcn
🤯
73fc790
@johnstcn johnstcn enabled auto-merge (squash) August 23, 2022 20:11
This was referenced Aug 23, 2022
Closed
Closed
@johnstcn johnstcn merged commit 6dacf70 into main Aug 23, 2022
@johnstcn johnstcn deleted the cj/gh-3286/update-usernames branch August 23, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsjoeio jsjoeio jsjoeio approved these changes

@Emyrk Emyrk Emyrk approved these changes

Assignees

@johnstcn johnstcn

@Emyrk Emyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Member user cannot update their username
4 participants
@johnstcn @jsjoeio @Emyrk @Kira-Pilot