Skip to content

ci: skip ts or go tests based on changed files #7134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jun 9, 2023
Merged

ci: skip ts or go tests based on changed files #7134

merged 15 commits into from
Jun 9, 2023

Conversation

deansheather
Copy link
Member

@deansheather deansheather commented Apr 14, 2023 •
edited
Loading

Closes #7147

BrunoQuaresma
BrunoQuaresma approved these changes Apr 14, 2023
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

matifali
matifali requested changes Apr 14, 2023
View reviewed changes
coadler
coadler approved these changes Apr 14, 2023
View reviewed changes
@matifali matifali self-requested a review April 26, 2023 13:20
@deansheather deansheather marked this pull request as draft April 26, 2023 13:22
@github-actions
Copy link

github-actions bot commented May 4, 2023

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actions github-actions bot added the stale This issue is like stale bread. label May 4, 2023
@matifali
Copy link
Member

matifali commented May 4, 2023

unstale. @deansheather

@github-actions github-actions bot removed the stale This issue is like stale bread. label May 5, 2023
@github-actions
Copy link

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actions github-actions bot added the stale This issue is like stale bread. label May 12, 2023
@matifali matifali removed the stale This issue is like stale bread. label May 12, 2023
@github-actions
Copy link

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actions github-actions bot added the stale This issue is like stale bread. label May 20, 2023
@github-actions github-actions bot closed this May 23, 2023
@johnstcn johnstcn reopened this May 23, 2023
@johnstcn johnstcn removed the stale This issue is like stale bread. label May 23, 2023
@kylecarbs kylecarbs removed their request for review May 24, 2023 15:46
@github-actions github-actions bot added the stale This issue is like stale bread. label Jun 1, 2023
@github-actions github-actions bot closed this Jun 5, 2023
@matifali matifali reopened this Jun 5, 2023
@github-actions github-actions bot removed the stale This issue is like stale bread. label Jun 6, 2023
@matifali matifali mentioned this pull request Jun 8, 2023
Closed
@matifali matifali changed the title chore: skip ts or go tests based on files changed ci: skip ts or go tests based on files changed Jun 9, 2023
@matifali matifali changed the title ci: skip ts or go tests based on files changed ci: skip ts or go tests based on changed files Jun 9, 2023
@matifali matifali self-assigned this Jun 9, 2023
@matifali matifali marked this pull request as ready for review June 9, 2023 17:12
@matifali matifali requested a review from ammario June 9, 2023 17:12
ammario
ammario requested changes Jun 9, 2023
View reviewed changes
Copy link
Member

@ammario ammario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this once before, but it caused issues because the required status checks would never pass on e.g. a docs PR.

We could get around that by checking the changed files in the run body, and exit 0 early if no relevant files changed.

In an ideal world, test caching would make all of this a non-issue.

@matifali
Copy link
Member

matifali commented Jun 9, 2023

I discussed this with @deansheather and he said that he will change the settings to make the new required job as required. So it will work in that case.

ammario
ammario approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@ammario ammario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever clever dean

@matifali
Copy link
Member

matifali commented Jun 9, 2023 •
edited
Loading

I added a new filter ci that will allow to run all tests if we make changes to .github directory.

@matifali matifali requested a review from mafredri June 9, 2023 18:37
@matifali matifali assigned deansheather and unassigned deansheather Jun 9, 2023
@matifali matifali added the chore label Jun 9, 2023
@matifali matifali merged commit 634e146 into main Jun 9, 2023
@matifali matifali deleted the dean/skip-tests-fe-be branch June 9, 2023 23:53
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

@coadler coadler coadler approved these changes

@ammario ammario ammario approved these changes

@matifali matifali matifali approved these changes

@mafredri mafredri Awaiting requested review from mafredri

Assignees

@matifali matifali

@deansheather deansheather

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

do not run go/ts tests for PRs that only target docs
7 participants
@deansheather @matifali @mafredri @BrunoQuaresma @coadler @ammario @johnstcn