Skip to content

feat: Auto select workspace proxy based on lowest latency #7515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 22, 2023
Merged

feat: Auto select workspace proxy based on lowest latency #7515

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
159538c
WIP: Proxy auto select and user selection state
Emyrk May 11, 2023
1305931
chore: Auto select based on latency
Emyrk May 12, 2023
d1c9f3f
Add extra test for unknown latencies
Emyrk May 12, 2023
c739f24
Move arg inside the funcs
Emyrk May 12, 2023
ae26777
Fmt
Emyrk May 12, 2023
523e492
Duplicate import
Emyrk May 12, 2023
877c0c9
PR feedback
Emyrk May 12, 2023
8d26643
Merge remote-tracking branch 'origin/main' into stevenmasley/proxy_la…
Emyrk May 12, 2023
5c534fa
Refactor
Emyrk May 12, 2023
a3703e1
Fix useEffect dep
Emyrk May 18, 2023
c210e8d
Merge remote-tracking branch 'origin/main' into stevenmasley/proxy_la…
Emyrk May 18, 2023
a358258
Fix deps comment
Emyrk May 18, 2023
ec860c3
Remove comment
Emyrk May 22, 2023
3197eb1
Merge remote-tracking branch 'origin/main' into stevenmasley/proxy_la…
Emyrk May 22, 2023
ebb6a76
Mock the hook with a hook
Emyrk May 22, 2023
549093e
Remove unused dep
Emyrk May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fmt
  • Loading branch information
@Emyrk
Emyrk committed May 12, 2023
commit ae2677736518a83e7f8b590dfd387a19f355e23b
5 changes: 4 additions & 1 deletion site/src/testHelpers/entities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1374,7 +1374,10 @@ export const MockEntitlementsWithScheduling: TypesGen.Entitlements = {
}),
}

export const MockExperiments: TypesGen.Experiment[] = ["workspace_actions", "moons"]
export const MockExperiments: TypesGen.Experiment[] = [
"workspace_actions",
"moons",
]

export const MockAuditLog: TypesGen.AuditLog = {
id: "fbd2116a-8961-4954-87ae-e4575bd29ce0",
Expand Down
24 changes: 12 additions & 12 deletions site/src/testHelpers/localstorage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
export const localStorageMock = () => {
const store = {} as Record<string, string>;
const store = {} as Record<string, string>

return {
getItem: (key: string):string =>{
return store[key];
getItem: (key: string): string => {
return store[key]
},
setItem: (key:string, value:string)=> {
store[key] = value;
setItem: (key: string, value: string) => {
store[key] = value
},
clear: ()=> {
clear: () => {
Object.keys(store).forEach((key) => {
delete store[key];
});
delete store[key]
})
},
removeItem: (key: string) => {
delete store[key]
},
removeItem: (key:string) => {
delete store[key];
}
}
}

Object.defineProperty(window, "localStorage", { value: localStorageMock() });
Object.defineProperty(window, "localStorage", { value: localStorageMock() })
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is being executed when the module is imported, maybe can be interesting to move all this code into the test setup file and mock it globally. We are doing that for a few default window interfaces.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe, I just wanted to avoid putting things in the global if my test was the only one using it atm.