coder · Emyrk · May 22, 2023 · May 11, 2023 · May 12, 2023 · May 12, 2023
diff --git a/site/jest.setup.ts b/site/jest.setup.ts
@@ -8,6 +8,7 @@ import { Blob } from "buffer"
 import jestFetchMock from "jest-fetch-mock"
 import { ProxyLatencyReport } from "contexts/useProxyLatency"
 import { RegionsResponse } from "api/typesGenerated"
+import { useMemo } from "react"
 
 jestFetchMock.enableMocks()
 
@@ -16,20 +17,25 @@ jestFetchMock.enableMocks()
 // actual network requests. So just globally mock this hook.
 jest.mock("contexts/useProxyLatency", () => ({
   useProxyLatency: (proxies?: RegionsResponse) => {
-    if (!proxies) {
-      return {} as Record<string, ProxyLatencyReport>
-    }
-
-    return proxies.regions.reduce((acc, proxy) => {
-      acc[proxy.id] = {
-        accurate: true,
-        // Return a constant latency of 8ms.
-        // If you make this random it could break stories.
-        latencyMS: 8,
-        at: new Date(),
+    // Must use `useMemo` here to avoid infinite loop.
+    // Mocking the hook with a hook.
+    const latencies = useMemo(() => {
+      if (!proxies) {
+        return {} as Record<string, ProxyLatencyReport>
       }
-      return acc
-    }, {} as Record<string, ProxyLatencyReport>)
+      return proxies.regions.reduce((acc, proxy) => {
+        acc[proxy.id] = {
+          accurate: true,
+          // Return a constant latency of 8ms.
+          // If you make this random it could break stories.
+          latencyMS: 8,
+          at: new Date(),
+        }
+        return acc
+      }, {} as Record<string, ProxyLatencyReport>)
+    }, [proxies])
+
+    return latencies
   },
 }))
 

diff --git a/site/src/components/AppLink/AppLink.stories.tsx b/site/src/components/AppLink/AppLink.stories.tsx
@@ -26,6 +26,9 @@ const Template: Story<AppLinkProps> = (args) => (
       setProxy: () => {
         return
       },
+      clearProxy: () => {
+        return
+      },
     }}
   >
     <AppLink {...args} />

diff --git a/site/src/components/Resources/AgentRow.stories.tsx b/site/src/components/Resources/AgentRow.stories.tsx
@@ -65,6 +65,9 @@ const TemplateFC = (
         setProxy: () => {
           return
         },
+        clearProxy: () => {
+          return
+        },
       }}
     >
       <AgentRow {...args} />

diff --git a/site/src/components/Resources/ResourceCard.stories.tsx b/site/src/components/Resources/ResourceCard.stories.tsx
@@ -30,6 +30,9 @@ Example.args = {
         setProxy: () => {
           return
         },
+        clearProxy: () => {
+          return
+        },
       }}
     >
       <AgentRow
@@ -97,6 +100,9 @@ BunchOfMetadata.args = {
         setProxy: () => {
           return
         },
+        clearProxy: () => {
+          return
+        },
       }}
     >
       <AgentRow

diff --git a/site/src/components/Workspace/Workspace.stories.tsx b/site/src/components/Workspace/Workspace.stories.tsx
@@ -47,6 +47,9 @@ const Template: Story<WorkspaceProps> = (args) => (
         proxies: [],
         isLoading: false,
         isFetched: true,
+        clearProxy: () => {
+          return
+        },
         setProxy: () => {
           return
         },

diff --git a/site/src/contexts/ProxyContext.test.ts b/site/src/contexts/ProxyContext.test.ts
-Original file line number
+Diff line change
@@ Expand Up / @@ -26,6 +26,9 @@ const Template: Story<AppLinkProps> = (args) => ( @@
           setProxy: () => {
             return
           },
+          clearProxy: () => {
+            return
+          },
         }}
       >
         <AppLink {...args} />
@@ Expand Down @@