Skip to content

feat: Auto select workspace proxy based on lowest latency #7515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 22, 2023
Merged

feat: Auto select workspace proxy based on lowest latency #7515

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
159538c
WIP: Proxy auto select and user selection state
Emyrk May 11, 2023
1305931
chore: Auto select based on latency
Emyrk May 12, 2023
d1c9f3f
Add extra test for unknown latencies
Emyrk May 12, 2023
c739f24
Move arg inside the funcs
Emyrk May 12, 2023
ae26777
Fmt
Emyrk May 12, 2023
523e492
Duplicate import
Emyrk May 12, 2023
877c0c9
PR feedback
Emyrk May 12, 2023
8d26643
Merge remote-tracking branch 'origin/main' into stevenmasley/proxy_la…
Emyrk May 12, 2023
5c534fa
Refactor
Emyrk May 12, 2023
a3703e1
Fix useEffect dep
Emyrk May 18, 2023
c210e8d
Merge remote-tracking branch 'origin/main' into stevenmasley/proxy_la…
Emyrk May 18, 2023
a358258
Fix deps comment
Emyrk May 18, 2023
ec860c3
Remove comment
Emyrk May 22, 2023
3197eb1
Merge remote-tracking branch 'origin/main' into stevenmasley/proxy_la…
Emyrk May 22, 2023
ebb6a76
Mock the hook with a hook
Emyrk May 22, 2023
549093e
Remove unused dep
Emyrk May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move arg inside the funcs
  • Loading branch information
@Emyrk
Emyrk committed May 12, 2023
commit c739f245f36b5127bc2d3c4a876f1c73b2cc1d88
16 changes: 8 additions & 8 deletions site/src/contexts/ProxyContext.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import { rest } from "msw"
import { Region } from "api/typesGenerated"
import "testHelpers/localstorage"
import userEvent from "@testing-library/user-event"
import UserEvent from "@testing-library/user-event"

// Mock useProxyLatency to use a hard-coded latency. 'jest.mock' must be called
// here and not inside a unit test.
Expand Down Expand Up @@ -176,7 +177,7 @@ interface ProxyContextSelectionTest {
latencies?: Record<string, ProxyLatency.ProxyLatencyReport>
// afterLoad are actions to take after loading the component, but before
// assertions. This is useful for simulating user actions.
afterLoad?: (user: typeof userEvent) => Promise<void>
afterLoad?: () => Promise<void>

// Assert these values.
// expProxyID is the proxyID returned to be used.
Expand All @@ -192,15 +193,15 @@ describe("ProxyContextSelection", () => {
})

// A way to simulate a user clearing the proxy selection.
const clearProxyAction = async (user: typeof userEvent): Promise<void> => {
const clearProxyAction = async (): Promise<void> => {
const user = userEvent.setup()
const clearProxyButton = screen.getByTestId("clearProxy")
await user.click(clearProxyButton)
}

const userSelectProxy = (
proxy: Region,
): ((user: typeof userEvent) => Promise<void>) => {
return async (user): Promise<void> => {
const userSelectProxy = (proxy: Region): (() => Promise<void>) => {
return async (): Promise<void> => {
const user = userEvent.setup()
const selectData = screen.getByTestId("userSelectProxyData")
selectData.innerText = JSON.stringify(proxy)

Expand Down Expand Up @@ -366,9 +367,8 @@ describe("ProxyContextSelection", () => {
TestingComponent()
await waitForLoaderToBeRemoved()

const user = userEvent.setup()
if (afterLoad) {
await afterLoad(user)
await afterLoad()
}

await screen.findByTestId("isFetched").then((x) => {
Expand Down