fix: set default sshMaxTimeout to 60s #7532
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #6724
Related: #7512
This PR sets the default SSH max timeout to a finite value. Without this setting, SSH connections can hang indefinitely, so in case of any failure, the connection is left as is and causes #7512.
Once we enable the timeout, coder agent will be able to report any troubles with broken agent connections:
Otherwise, the agent assumes that the connection gets back to life eventually (hence no error trace in logs)