Skip to content

feat: allow external services to be authable #9996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Oct 3, 2023
Merged

feat: allow external services to be authable #9996

merged 21 commits into from
Oct 3, 2023

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented Oct 2, 2023 •
edited
Loading

Allows external services to be authenticated with Coder via "Create Workspace".

Shortlist of changes:

  1. Renamed environment variables from CODER_GITAUTH_ to CODER_EXTERNAL_AUTH_ (this is backwards compatible).
  2. New DISPLAY_NAME and DISPLAY_ICON properties.
  3. Newew TYPE=oidc to enable any OpenID Connect provider to work with external auth.

image

Future improvements:

  1. Add a sub-command to the Coder CLI to dynamically obtain the access token from a provider. e.g. coder external-auth refresh --type=github, coder external-auth refresh --id=github, coder external-auth refresh --match="https://github.com"
  2. Add coder_external_auth Terraform data source to replace coder_git_auth. Allow for matching based on type and regex so Modules can make use of auth 👀.

@kylecarbs kylecarbs self-assigned this Oct 2, 2023
@kylecarbs kylecarbs marked this pull request as ready for review October 2, 2023 16:26
@kylecarbs
Copy link
Member Author

@bpmct please review the docs on this change.

We also need to add a permanent redirect for coder.com from /docs/v2/admin/git-auth to /docs/v2/admin/external-auth.

BrunoQuaresma
BrunoQuaresma approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE code looks good but there are a few Storybook stories broken

@kylecarbs
Copy link
Member Author

Fixed! Good call on checking the Storybook.

@github-actions
Copy link

github-actions bot commented Oct 2, 2023 •
edited
Loading

✔️ PR 9996 Updated successfully.
🚀 Access the credentials here.

cc: @kylecarbs

@kylecarbs kylecarbs enabled auto-merge (squash) October 2, 2023 22:07
@kylecarbs kylecarbs merged commit 45b53c2 into main Oct 3, 2023
@kylecarbs kylecarbs deleted the extauthprovider branch October 3, 2023 14:04
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

@bpmct bpmct Awaiting requested review from bpmct

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylecarbs @BrunoQuaresma