Skip to content

Add header command setting #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 22, 2023
Merged

Add header command setting #303

merged 11 commits into from
Sep 22, 2023

Conversation

code-asher
Copy link
Member

Closes #293

@code-asher code-asher force-pushed the asher/header-command branch 2 times, most recently from b60c0d4 to 93a6f0d Compare September 19, 2023 17:46
@code-asher code-asher force-pushed the asher/header-command branch 3 times, most recently from 14dd5c4 to 0fdc6f5 Compare September 19, 2023 21:51
@code-asher
Add headers to API requests
9a9dedf
@code-asher
Update changelog with header command
af0487f
@code-asher
Add --info to CI tests
06c7fb0 
It seems the default is to say a test fails but give no explanation as
to why.
@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2023 •
edited
Loading

Qodana Community for JVM

55 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 32
Unstable API Usage 🔶 Warning 8
Incorrect string capitalization 🔶 Warning 7
Call to 'equals()' or 'hashCode()' on 'URL' object 🔶 Warning 2
Local 'var' is never modified and can be declared as 'val' 🔶 Warning 1
Redundant semicolon 🔶 Warning 1
Useless call on not-null type 🔶 Warning 1
Class member can have 'private' visibility ◽️ Notice 1
Size check can be replaced with 'isNotEmpty()' ◽️ Notice 1
Trailing comma recommendations ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.2.6
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@code-asher code-asher marked this pull request as ready for review September 19, 2023 22:21
@code-asher code-asher requested a review from johnstcn September 19, 2023 22:21
johnstcn
johnstcn reviewed Sep 20, 2023
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could use a bit of beefing up of the header command escaping. Check https://github.com/coder/coder/blob/main/cli/configssh.go#L787-L810 to see what we currently do in the CLI, that seems like it could be applicable here.

@code-asher code-asher requested a review from johnstcn September 22, 2023 12:17
johnstcn
johnstcn reviewed Sep 22, 2023
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK to me. I tagged @mafredri to take a look as they've had to wrestle with this in the past.

@mafredri
Copy link
Member

This looks OK to me. I tagged @mafredri to take a look as they've had to wrestle with this in the past.

Looks OK to me too!

@code-asher code-asher merged commit a6efd99 into main Sep 22, 2023
@code-asher code-asher deleted the asher/header-command branch September 22, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnstcn johnstcn johnstcn approved these changes

Assignees

@code-asher code-asher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement settings for --header-command
3 participants
@code-asher @mafredri @johnstcn