Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cpp-linter/cpp-linter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e640af3
Choose a base ref
...
head repository: cpp-linter/cpp-linter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cc8b181
Choose a head ref
  • 16 commits
  • 94 files changed
  • 2 contributors

Commits on Jan 1, 2024

  1. make verbosity disabled by default (#47)

    Users can still enable verbosity by re-running a CI job with debugging logs enabled.
    
    Not outputting debug logs in production will save users billable CI runtime.
    2bndy5 authored Jan 1, 2024
    Configuration menu
    Copy the full SHA
    d1d07c7 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. downgrade up/download-artifacts in testing CI

    try codacy coverage analysis
    2bndy5 committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    5f67781 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. complete refactor (#49)

    - Functions are properly organized in modules with appropriate names.
    - REST API usage is isolated in class derived from an abstract base class that will easily allow integrating other git servers' REST API.
    - clang-format output is filtered by lines (when applicable) as the XML is parsed.
    - The comment is made after all clang tool output is parsed.
    - All clang tool output is parsed from buffered strings (addresses #48).
    - There isn't any cached files when verbosity is not set to debug mode.
    - Tests can now use mocked HTTP requests (no more fear of hitting REST API rate limits).
    - Updated docs to reflect the new package structure.
    - CLI supports file paths/names given as positional args
    - Removed dead code about previous attempt to create review comments
    - Change acceptable verbosity input values to be "debug" or "10"
    - Updated help strings in CLI for narrow terminals
    - fix problem in "is ignored" logic
      Due to python's lazy logic evaluation, we need to check if a path is first explicitly not-ignored before checking if said source is ignored.
    2bndy5 authored Jan 4, 2024
    Configuration menu
    Copy the full SHA
    ecff34c View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2024

  1. Link clang-tidy diagnostic names to clang-tidy docs (#52)

    * hyperlink to clang-tidy diagnostic docs
    * rename some TidyNotification properties
    * encapsulate list of TidyNotification objects in TidyAdvice class for stronger typing
    2bndy5 authored Jan 6, 2024
    Configuration menu
    Copy the full SHA
    10583d4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a322749 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. thread-comments are not exclusive to github-actions bot (#53)

    This fixes the thread-comments feature when users specify a personal access token instead of the generic `GITUHB_TOKEN`
    
    Thankfully, we can still identify our generated comments using the action-specific HTML comment embedded in the beginning of the comment text.
    
    Note: The HTML comment is only seen for public repositories. For private repos, the comment's body fetched by REST API is in plain text (with HTML syntax removed).
    2bndy5 authored Jan 8, 2024
    Configuration menu
    Copy the full SHA
    3cca935 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. PR Review Suggestions (#51)

    * get diff of suggestions for each files (from each clang tool)
    * support PR reviews for individual tool's output
      - keep suggestions within 1 diff hunk
      - use default SHA for review commit_id
      - only create a Patch when creating a review
      - don't post reviews for PRs marked as "draft" or "closed"
    * add test
    * allow 2% drop (maximum) in coverage on CI checks
    * get file changes for review when analyzing all files
    2bndy5 authored Jan 10, 2024
    Configuration menu
    Copy the full SHA
    a44161d View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2024

  1. Configuration menu
    Copy the full SHA
    5c3921a View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. Configuration menu
    Copy the full SHA
    788596b View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2024

  1. remove duplicated file name in tidy comment (#64)

    * remove duplicated file name in tidy comment
      resolves #63
      Technically, this fixes an undesired behavior introduced in #49.
    * use MD bold syntax when not using raw HTML syntax
    2bndy5 authored Feb 10, 2024
    Configuration menu
    Copy the full SHA
    134c898 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2024

  1. resolves #65 (#66)

    * resolves #65
    
    This will remove the line "No objections from ..." when it is not relevant in PR review summary comments.
    
    Also adds a 🎉 for approved PR reviews
    
    * change logic about traversing advice for different tools
    
    * show cmd used to get fixes in logs
    
    * don't add quotes around extra-arg value
    
    * correct order of arg to post_feedback()
    
    use kwargs to avoid mis-ordering positional args
    2bndy5 authored Feb 11, 2024
    Configuration menu
    Copy the full SHA
    2cb6422 View commit details
    Browse the repository at this point in the history
  2. allow PR review with no suggestions in diff (#68)

    * allow PR review summary without suggestions
      resolves #67
      This is intended to let users reduce comments posted in PR reviews.
    * add test condition
    2bndy5 authored Feb 11, 2024
    Configuration menu
    Copy the full SHA
    5ad8d43 View commit details
    Browse the repository at this point in the history
  3. bump the major versions of some GH actions (#69)

    The idea is to satisfy the deprecation of actions that still use node.js v16.
    
    Actions that are bumped here use node.js v20
    2bndy5 authored Feb 11, 2024
    Configuration menu
    Copy the full SHA
    608682a View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. document PR review feature caveats (#70)

    This is mostly taken from a comment I posted in cpp-linter/cpp-linter-action#182 with some updates.
    Also reviewed other changes about the generated cli_args.rst document.
    2bndy5 authored Feb 12, 2024
    Configuration menu
    Copy the full SHA
    7dce923 View commit details
    Browse the repository at this point in the history
  2. bump codecov-action to v4 (#71)

    * bump codecov-action to v4
    
    uses node.js v20 instead of deprecated node.js v16
    
    also uses token in an env var as recommended by codecov docs
    
    * enable dependabot
    2bndy5 authored Feb 12, 2024
    Configuration menu
    Copy the full SHA
    03934bb View commit details
    Browse the repository at this point in the history
  3. Auto update doc copyright year (#72)

    * automatically set docs' copyright and version
    * doc builds use editable install of cpp-linter pkg
    2bndy5 authored Feb 12, 2024
    Configuration menu
    Copy the full SHA
    cc8b181 View commit details
    Browse the repository at this point in the history
Loading