-
-
Notifications
You must be signed in to change notification settings - Fork 8
Comparing changes
Open a pull request
base repository: cpp-linter/cpp-linter
base: e640af3
head repository: cpp-linter/cpp-linter
compare: cc8b181
- 16 commits
- 94 files changed
- 2 contributors
Commits on Jan 1, 2024
-
make verbosity disabled by default (#47)
Users can still enable verbosity by re-running a CI job with debugging logs enabled. Not outputting debug logs in production will save users billable CI runtime.
Configuration menu - View commit details
-
Copy full SHA for d1d07c7 - Browse repository at this point
Copy the full SHA d1d07c7View commit details
Commits on Jan 3, 2024
-
downgrade up/download-artifacts in testing CI
try codacy coverage analysis
Configuration menu - View commit details
-
Copy full SHA for 5f67781 - Browse repository at this point
Copy the full SHA 5f67781View commit details
Commits on Jan 4, 2024
-
- Functions are properly organized in modules with appropriate names. - REST API usage is isolated in class derived from an abstract base class that will easily allow integrating other git servers' REST API. - clang-format output is filtered by lines (when applicable) as the XML is parsed. - The comment is made after all clang tool output is parsed. - All clang tool output is parsed from buffered strings (addresses #48). - There isn't any cached files when verbosity is not set to debug mode. - Tests can now use mocked HTTP requests (no more fear of hitting REST API rate limits). - Updated docs to reflect the new package structure. - CLI supports file paths/names given as positional args - Removed dead code about previous attempt to create review comments - Change acceptable verbosity input values to be "debug" or "10" - Updated help strings in CLI for narrow terminals - fix problem in "is ignored" logic Due to python's lazy logic evaluation, we need to check if a path is first explicitly not-ignored before checking if said source is ignored.
Configuration menu - View commit details
-
Copy full SHA for ecff34c - Browse repository at this point
Copy the full SHA ecff34cView commit details
Commits on Jan 6, 2024
-
Link clang-tidy diagnostic names to clang-tidy docs (#52)
* hyperlink to clang-tidy diagnostic docs * rename some TidyNotification properties * encapsulate list of TidyNotification objects in TidyAdvice class for stronger typing
Configuration menu - View commit details
-
Copy full SHA for 10583d4 - Browse repository at this point
Copy the full SHA 10583d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for a322749 - Browse repository at this point
Copy the full SHA a322749View commit details
Commits on Jan 8, 2024
-
thread-comments are not exclusive to github-actions bot (#53)
This fixes the thread-comments feature when users specify a personal access token instead of the generic `GITUHB_TOKEN` Thankfully, we can still identify our generated comments using the action-specific HTML comment embedded in the beginning of the comment text. Note: The HTML comment is only seen for public repositories. For private repos, the comment's body fetched by REST API is in plain text (with HTML syntax removed).
Configuration menu - View commit details
-
Copy full SHA for 3cca935 - Browse repository at this point
Copy the full SHA 3cca935View commit details
Commits on Jan 10, 2024
-
* get diff of suggestions for each files (from each clang tool) * support PR reviews for individual tool's output - keep suggestions within 1 diff hunk - use default SHA for review commit_id - only create a Patch when creating a review - don't post reviews for PRs marked as "draft" or "closed" * add test * allow 2% drop (maximum) in coverage on CI checks * get file changes for review when analyzing all files
Configuration menu - View commit details
-
Copy full SHA for a44161d - Browse repository at this point
Copy the full SHA a44161dView commit details
Commits on Jan 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5c3921a - Browse repository at this point
Copy the full SHA 5c3921aView commit details
Commits on Feb 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 788596b - Browse repository at this point
Copy the full SHA 788596bView commit details
Commits on Feb 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 134c898 - Browse repository at this point
Copy the full SHA 134c898View commit details
Commits on Feb 11, 2024
-
* resolves #65 This will remove the line "No objections from ..." when it is not relevant in PR review summary comments. Also adds a 🎉 for approved PR reviews * change logic about traversing advice for different tools * show cmd used to get fixes in logs * don't add quotes around extra-arg value * correct order of arg to post_feedback() use kwargs to avoid mis-ordering positional args
Configuration menu - View commit details
-
Copy full SHA for 2cb6422 - Browse repository at this point
Copy the full SHA 2cb6422View commit details -
allow PR review with no suggestions in diff (#68)
* allow PR review summary without suggestions resolves #67 This is intended to let users reduce comments posted in PR reviews. * add test condition
Configuration menu - View commit details
-
Copy full SHA for 5ad8d43 - Browse repository at this point
Copy the full SHA 5ad8d43View commit details -
bump the major versions of some GH actions (#69)
The idea is to satisfy the deprecation of actions that still use node.js v16. Actions that are bumped here use node.js v20
Configuration menu - View commit details
-
Copy full SHA for 608682a - Browse repository at this point
Copy the full SHA 608682aView commit details
Commits on Feb 12, 2024
-
document PR review feature caveats (#70)
This is mostly taken from a comment I posted in cpp-linter/cpp-linter-action#182 with some updates. Also reviewed other changes about the generated cli_args.rst document.
Configuration menu - View commit details
-
Copy full SHA for 7dce923 - Browse repository at this point
Copy the full SHA 7dce923View commit details -
bump codecov-action to v4 (#71)
* bump codecov-action to v4 uses node.js v20 instead of deprecated node.js v16 also uses token in an env var as recommended by codecov docs * enable dependabot
Configuration menu - View commit details
-
Copy full SHA for 03934bb - Browse repository at this point
Copy the full SHA 03934bbView commit details -
Auto update doc copyright year (#72)
* automatically set docs' copyright and version * doc builds use editable install of cpp-linter pkg
Configuration menu - View commit details
-
Copy full SHA for cc8b181 - Browse repository at this point
Copy the full SHA cc8b181View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff e640af3...cc8b181