Skip to content
This repository was archived by the owner on Sep 18, 2023. It is now read-only.

Removal of conflicting rec #47

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Conversation

khiga8
Copy link
Contributor

@khiga8 khiga8 commented Apr 13, 2022

Fixes: #46

Removes conflicting recommendation to minimize confusion.

@khiga8 khiga8 requested a review from a team as a code owner April 13, 2022 16:44
@khiga8 khiga8 requested a review from dgreif April 13, 2022 16:44
Copy link

@dgreif dgreif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂 good catch

@dgreif
Copy link

dgreif commented Apr 13, 2022

@koddsson could you confirm we should remove this recommendation based on our research yesterday?

@koddsson
Copy link
Contributor

Oh yeah, this is great. Thanks!

@koddsson koddsson merged commit b9b5689 into github:main Apr 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no-dom-traversal-in-attributechangedcallback recommendation conflicts with no-dom-traversal-in-connectedcallback
3 participants