-
-
Notifications
You must be signed in to change notification settings - Fork 849
Use closed_at and merged_at when filtering issues/prs #504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use closed_at and merged_at when filtering issues/prs #504
Conversation
Hi! Glad you took the time to make a PR! In order to explain what it does, can we add a test of some kind that proves/explains how merged_at and closed_at are the field we wish to use? |
Maybe all it takes is a bit of documentation in the code, as docstrings (YARD) for this method? |
@olleolleolle would that work? |
@olleolleolle let me know if there is anything else that you want me to do here. Thanks 😄 |
…tor into issue_503_wrong_tag
…gelog-generator into issue_503_wrong_tag
@olleolleolle merged PR with master, Travis is green again :-) |
since apologies for the noise, I clicked on the wrong button |
@olleolleolle Any chance of getting this merged? We've bumped into the same issue on https://github.com/voxpupuli/puppet-rabbitmq. @wyardley Could you link to your branch that demonstrates this issue? |
@olleolleolle Thanks! |
Fixes #503 in my tests with our private repo.