Skip to content

Use closed_at and merged_at when filtering issues/prs #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

unicolet
Copy link
Contributor

Fixes #503 in my tests with our private repo.

@olleolleolle
Copy link
Collaborator

Hi! Glad you took the time to make a PR!

In order to explain what it does, can we add a test of some kind that proves/explains how merged_at and closed_at are the field we wish to use?

@olleolleolle
Copy link
Collaborator

Maybe all it takes is a bit of documentation in the code, as docstrings (YARD) for this method?

@unicolet
Copy link
Contributor Author

@olleolleolle would that work?

@unicolet
Copy link
Contributor Author

@olleolleolle let me know if there is anything else that you want me to do here. Thanks 😄

@unicolet
Copy link
Contributor Author

unicolet commented Jun 6, 2017

@olleolleolle merged PR with master, Travis is green again :-)

@unicolet
Copy link
Contributor Author

unicolet commented Jun 7, 2017

since apologies for the noise, I clicked on the wrong button

@alexjfisher
Copy link
Contributor

@olleolleolle Any chance of getting this merged? We've bumped into the same issue on https://github.com/voxpupuli/puppet-rabbitmq. @wyardley Could you link to your branch that demonstrates this issue?

@olleolleolle olleolleolle merged commit 1f68ef8 into github-changelog-generator:master Sep 30, 2017
@alexjfisher
Copy link
Contributor

@olleolleolle Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants