@DonovanDeSmedt Great work dude! Do you mind adding a quick video showing it works?

@ZAKdev as you were the one who added heatmap and you work often with it, do you mind taking a quick look?

@itsmichaeldiego thx, was quiet busy last week, I'll make a video tomorrow.

A small example video of this feature:
https://drive.google.com/file/d/1at53N8L4BaktsP2ucipl6Rd_6P_lk92e/view?usp=sharing

Only negative point that could be improved is the visual rerender of the map (map becomes grey for a second before a rerender). It would improve the UX if the map would rerender smoothly, without a visual grey interval...

@DonovanDeSmedt BTW, I just fixed the build and in order to do so I've to fix the linter, so you might have to rebase and remove the fix linting comment. Let me know if you don't have time and I can do it for you.

Feel free to do it for me, I messed up some things locally :(

Added support for extra google map api libraries:

• Drawing library
• Geometry library
• Places library

Updated the rerender of heatmap when the prop updateHeatmap is set to true (no more flickering). Map is just being rerendered without being initialised again.

@DonovanDeSmedt Great work man! I might need you to add it to the documentation so users know that this is a possibility! (To use this libraries). And I will create a minor release asap.

@itsmichaeldiego Indeed, that's necessary. I'll update the documentation in the readme.

@DonovanDeSmedt Thanks! Looking forward for it!

@itsmichaeldiego Can you check the updated readme to verify there is enough information about the change in this pr?

@DonovanDeSmedt Looks great, thanks man! I will merge it soon

@DonovanDeSmedt Merged and deployed in version 1.1.0, please try it and let me know

@DonovanDeSmedt This created an issue: #673

Let me know if you can take a look at that, because the older way of using libraries stopped working

Maybe we should change the approach to use heatmapLibrary the same way we used to add the libraries in the URL:

<GoogleMapReact
  bootstrapURLKeys={{
    key: 'xxxxxxxxxxxxxx',
    libraries: ['places', 'drawing', 'heatmap']
  }}
  yesIWantToUseGoogleMapApiInternals
  onGoogleApiLoaded={({ maps }) => {
    console.log(maps.places);
    console.log(maps.drawing);
  }}
/>

@DonovanDeSmedt This created an issue: #673

Let me know if you can take a look at that, because the older way of using libraries stopped working

Maybe we should change the approach to use heatmapLibrary the same way we used to add the libraries in the URL:

<GoogleMapReact
  bootstrapURLKeys={{
    key: 'xxxxxxxxxxxxxx',
    libraries: ['places', 'drawing', 'heatmap']
  }}
  yesIWantToUseGoogleMapApiInternals
  onGoogleApiLoaded={({ maps }) => {
    console.log(maps.places);
    console.log(maps.drawing);
  }}
/>

Ok, I'll update it, by the weekend at the latest.
Do I offer both ways to use the libraries at the moment and deprecate the 'wrong' way in the next release?

Correct way:

<GoogleMapReact
  bootstrapURLKeys={{
    key: 'xxxxxxxxxxxxxx',
    libraries: ['places', 'drawing', 'heatmap']
  }}
  yesIWantToUseGoogleMapApiInternals
  onGoogleApiLoaded={({ maps }) => {
    console.log(maps.places);
    console.log(maps.drawing);
  }}
/>

Wrong way:

<GoogleMapReact
  bootstrapURLKeys={{
    key: 'xxxxxxxxxxxxxx',
  }}
  yesIWantToUseGoogleMapApiInternals
  drawingLibrary={true}
  placesLibrary ={true}
  onGoogleApiLoaded={({ maps }) => {
    console.log(maps.places);
    console.log(maps.drawing);
  }}
/>

@DonovanDeSmedt Lets just use the "correct way" :D

drawingLibrary={true}
placesLibrary ={true}

OMG! I can't believe you changed an important API without any notice, updating docs and release log. This is super critical and ppl are using this component in a serious business and product. Please bring back the wrong way, anyway.

The new implemenation of loading libraries was added to be consistent with the heatmap library (as described in the api docs).

drawingLibrary={true} 

This implementation no longer supported the previous way

bootstrapURLKeys={{
    key: 'xxxxxxxxxxxxxx',
    libraries: ['places', 'drawing', 'heatmap']
  }} 

It was released in release 1.1.0 but it should indeed be backward compatible. Hence my pr to fix this issue (and support both ways) if that's wanted.

Thanks @DonovanDeSmedt! Great input, I already answered in your PR, I think the heatmap change was created a few months back by @ZAKdev and I did not remember that we already had another way to handle libraries, that was my mistake. I would keep it the old way, just importing libraries with the array.

@snhasani We fixed this and released 1.1.1

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.