Skip to content

Custom div style options #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 29, 2018
Merged

Custom div style options #634

merged 5 commits into from
Sep 29, 2018

Conversation

jurgenzz
Copy link
Contributor

@jurgenzz jurgenzz commented Aug 27, 2018 •
edited
Loading

fixes #632

@jurgenzz jurgenzz changed the title #632 Custom div style options Custom div style options Aug 27, 2018
@jurgenzz
Copy link
Contributor Author

jurgenzz commented Aug 27, 2018 •
edited
Loading

Usage:

 <GoogleMapReact
    divStyleOptions={{
      pointerEvents: "none"
    }}
 />

itsmichaeldiego
itsmichaeldiego reviewed Sep 1, 2018
View reviewed changes
Copy link
Member

@itsmichaeldiego itsmichaeldiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are looking good, just one minor comment, what about calling it wrapperStyleOptions? I think its more accurate.

@jurgenzz
Copy link
Contributor Author

jurgenzz commented Sep 1, 2018

I'd guess no, as for name wrapper i would think of the div surrounding <GoogleMapReact /> component itself, not just marker, which actually goes into a pane. A lot of other overlays there :) . Then we could think of markerContainerStyle and other, but by just having a quick look at source, you'd figure out that this.div is probably getting all the styles. But i can change to something else tomorrow :)

@itsmichaeldiego
Copy link
Member

@jurgenzz Yes, I think we could find a more descriptive name for this, as this div can be any div.

@itsmichaeldiego
Copy link
Member

@jurgenzz How are we looking on this? I would like to merge it and release it so we can close #632

@jurgenzz
Copy link
Contributor Author

@itsmichaeldiego sorry, didn't have time before. I've updated it now -> overlayViewDivStyle

@itsmichaeldiego
Copy link
Member

@jurgenzz That is great! Thanks, I just realize something (sorry I didn't before) but we need to add this to the DOCS so other people know is there, more specifically in the API.md file

@jurgenzz
Copy link
Contributor Author

If you want, you can release it as it is for now. I've created reminder for Monday, when i'll be at work i'll update docs and API.md file.

@itsmichaeldiego
Copy link
Member

@jurgenzz We can wait, thanks!

@itsmichaeldiego
Copy link
Member

@jurgenzz How are we looking on this one? :D Looking forward to merge it

@jurgenzz
Copy link
Contributor Author

Ye, sorry, updated now :)

@itsmichaeldiego
Copy link
Member

@jurgenzz Great work man! I am releasing this in 1.0.9!

@itsmichaeldiego itsmichaeldiego merged commit 53e0979 into google-map-react:master Sep 29, 2018
@itsmichaeldiego itsmichaeldiego mentioned this pull request Sep 29, 2018
Merged
@itsmichaeldiego
Copy link
Member

itsmichaeldiego commented Sep 29, 2018 •
edited
Loading

@jurgenzz Released in 1.0.9! Please let me know if it works.

DonovanDeSmedt added a commit to DonovanDeSmedt/google-map-react that referenced this pull request Nov 21, 2018
@DonovanDeSmedt
Merge branch 'master' of github.com:google-map-react/google-map-react
ad9e522 
* 'master' of github.com:google-map-react/google-map-react:
  Bump to 1.1.1 (google-map-react#680)
  Revert "Added feature: update heat map on data change + fix linting" (google-map-react#679)
  Bump version to 1.1.0 (google-map-react#671)
  Added feature: update heat map on data change + fix linting (google-map-react#593)
  Pass map instance to onDrag handler (google-map-react#656)
  add math abs to avoid negative values when calculating zoom (google-map-react#655)
  Bump version to 1.0.9 (google-map-react#651)
  Custom div style options (google-map-react#634)
  Bump version to 1.0.8 (google-map-react#646)
  Revert 643 fix/map context (google-map-react#645)
  Bump version to 1.0.7 (google-map-react#644)
  Add passive scroll (google-map-react#631)
  Use React 16 portal to render map overlay (google-map-react#643)
  Fix old examples links and add one to new examples (google-map-react#633)
  Bump version to 1.0.6 (google-map-react#621)
  Add prop `onTilesLoaded` (google-map-react#615)
  Fix typo, and call fromContainerPixelToLatLng() as you would expect. (google-map-react#620)
  Update API.md (google-map-react#611)
  Upgrade version to 1.0.5 (google-map-react#607)
  Remove marker jiggle. (google-map-react#603)
@lock
Copy link

lock bot commented Dec 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@itsmichaeldiego itsmichaeldiego itsmichaeldiego left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom overlayview style attributes
2 participants
@jurgenzz @itsmichaeldiego