compiler/prelude: move prelude to separate .js files #791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 16, 2018
22e0772 to
dcfaa84
Compare
|
@hajimehoshi @shurcooL - yes, #791 (this PR) is ready for review. It's fully rebased on top of the most recent changes in #784. As I mentioned in #793 we need to make a decision on whether we merge:
or something else. |
myitcv
added a commit
to myitcv/gopherjs
that referenced
this pull request
Apr 18, 2018
This PR introduces automatic formatting of the prelude's now separate .js files. Using prettier has the same argument as using gofmt on .go source code. As part of this we make the go generate step for the prelude include a formatpreludejs.go step. The resulting prelude_min.go file is slightly different now, but post gopherjs#791 we can see these differences are entirely and solely attributable to prettier's adjusting of the .js files.
db1b319 to
282938b
Compare
myitcv
added a commit
to myitcv/gopherjs
that referenced
this pull request
Apr 20, 2018
This PR introduces automatic formatting of the prelude's now separate .js files. Using prettier has the same argument as using gofmt on .go source code. As part of this we make the go generate step for the prelude include a formatpreludejs.go step. The resulting prelude_min.go file is slightly different now, but post gopherjs#791 we can see these differences are entirely and solely attributable to prettier's adjusting of the .js files.
|
This has now been rebased against |
myitcv
added a commit
to myitcv/gopherjs
that referenced
this pull request
Apr 20, 2018
This PR introduces automatic formatting of the prelude's now separate .js files. Using prettier has the same argument as using gofmt on .go source code. As part of this we make the go generate step for the prelude include a formatpreludejs.go step. The resulting prelude_min.go file is slightly different now, but post gopherjs#791 we can see these differences are entirely and solely attributable to prettier's adjusting of the .js files.
myitcv
added a commit
to myitcv/gopherjs
that referenced
this pull request
Apr 21, 2018
This PR introduces automatic formatting of the prelude's now separate .js files. Using prettier has the same argument as using gofmt on .go source code. As part of this we make the go generate step for the prelude include a formatpreludejs.go step. The resulting prelude_min.go file is slightly different now, but post gopherjs#791 we can see these differences are entirely and solely attributable to prettier's adjusting of the .js files.
myitcv
added a commit
to myitcv/gopherjs
that referenced
this pull request
Apr 22, 2018
This PR introduces automatic formatting of the prelude's now separate .js files. Using prettier has the same argument as using gofmt on .go source code. As part of this we make the go generate step for the prelude include a formatpreludejs.go step. The resulting prelude_min.go file is slightly different now, but post gopherjs#791 we can see these differences are entirely and solely attributable to prettier's adjusting of the .js files.
I've been working with the prelude quite a lot recently. One of the really painful things with the current implementation is that the JavaScript for the prelude exists as a const string in a .go file, which makes properly writing and formatting the JavaScript itself very difficult. This PR splits the prelude into separate .js files to make editing the JavaScript prelude more straightforward. genmin.go becomes genprelude.go where these .js files are catted together into a single prelude.go file. The minified prelude_min.go is as before. Automated formatting of these .js files will follow in a later PR.
myitcv
added a commit
to myitcv/gopherjs
that referenced
this pull request
May 4, 2018
This PR introduces automatic formatting of the prelude's now separate .js files. Using prettier has the same argument as using gofmt on .go source code. As part of this we make the go generate step for the prelude include a formatpreludejs.go step. The resulting prelude_min.go file is slightly different now, but post gopherjs#791 we can see these differences are entirely and solely attributable to prettier's adjusting of the .js files.
myitcv
added a commit
to myitcv/gopherjs
that referenced
this pull request
Jul 2, 2018
This PR introduces automatic formatting of the prelude's now separate .js files. Using prettier has the same argument as using gofmt on .go source code. As part of this we make the go generate step for the prelude include a formatpreludejs.go step. The resulting prelude_min.go file is slightly different now, but post gopherjs#791 we can see these differences are entirely and solely attributable to prettier's adjusting of the .js files.
myitcv
added a commit
to myitcv/gopherjs
that referenced
this pull request
Jul 2, 2018
This PR introduces automatic formatting of the prelude's now separate .js files. Using prettier has the same argument as using gofmt on .go source code. As part of this we make the go generate step for the prelude include a formatpreludejs.go step. The resulting prelude_min.go file is slightly different now, but post gopherjs#791 we can see these differences are entirely and solely attributable to prettier's adjusting of the .js files.
myitcv
added a commit
to myitcv/gopherjs
that referenced
this pull request
Jul 2, 2018
This PR introduces automatic formatting of the prelude's now separate .js files. Using prettier has the same argument as using gofmt on .go source code. As part of this we make the go generate step for the prelude include a formatpreludejs.go step. The resulting prelude_min.go file is slightly different now, but post gopherjs#791 we can see these differences are entirely and solely attributable to prettier's adjusting of the .js files.
|
Is this still relevant? Will it remain relevant if we switch to Go 1.16's use of Thoughts @nevkontakte ? |
|
As this PR is no longer mergable, and will need to effectively be done from scratch, I'm going to close it. Further, @nevkontakte and I have discussed this, and he has some good ideas on improving the prelude handling which will render this PR obsolete, so he'll soon file a new issue to track progress on this front. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working with the prelude quite a lot recently. One of the really painful things with the current implementation is that the JavaScript for the prelude exists as a
conststring in a.gofile, which makes properly writing and formatting the Javascript itself very difficult.This PR splits the prelude into separate
.jsfiles therefore and adds aformatpreludejs.gogo generate-er to format those.jsfiles in place.