Skip to content

Modernification #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Modernification #1096

wants to merge 6 commits into from

Conversation

avocadowastaken
Copy link
Contributor

@avocadowastaken avocadowastaken commented Mar 5, 2017

  • yarn
  • remove jshint in favor of eslint
  • prettier
  • transpile src with babel
  • transpile docs with babel
  • remove gulp in favor of npm scripts
  • remove grunt in favor of npm scripts

See #742

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@avocadowastaken
Copy link
Contributor Author

And first problem.

According to the spec - es6 classes can not be called as a functions.

Few solutions:

  1. Make a breaking change and disalow var map = Map() syntax in favor of var map = new Map().
  2. Refactor all es6 classes to Function.prototype style.
  3. Keep using declassify (but first - need to fix it for latest rollup).

"comma-dangle": 0,
"space-before-function-paren": 0,
"curly": 0,
"no-empty": "warn",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I marked with warn rules that preferred to be error.
Most of them can be fixed with --fix flag.

@leebyron
Copy link
Collaborator

leebyron commented Mar 7, 2017

Hey @umidbekkarimov thanks for digging into this!

#742 is a master task for modernification, it's important for each actual change to be focused and incremental. Could you separate this into separate pull requests?

@avocadowastaken avocadowastaken mentioned this pull request Mar 7, 2017
@avocadowastaken
Copy link
Contributor Author

Done 👍. I'm closing this PR for now.

@avocadowastaken avocadowastaken mentioned this pull request Mar 7, 2017
15 tasks
@avocadowastaken avocadowastaken deleted the modernification branch March 7, 2017 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants