-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Modernification #1096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernification #1096
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
And first problem. According to the spec - es6 classes can not be called as a functions. Few solutions:
|
"comma-dangle": 0, | ||
"space-before-function-paren": 0, | ||
"curly": 0, | ||
"no-empty": "warn", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I marked with warn
rules that preferred to be error
.
Most of them can be fixed with --fix
flag.
Hey @umidbekkarimov thanks for digging into this! #742 is a master task for modernification, it's important for each actual change to be focused and incremental. Could you separate this into separate pull requests? |
Done 👍. I'm closing this PR for now. |
See #742