[5.1+] Fallback for "clear-compiled" command when vendors not yet installed #3694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @barryvdh 🎁 |
97d6fa2 to
0daf705
Compare
|
Another solution may be to rather put this in a new script |
|
I targeted the wrong branch, this PR was intended for 5.1 branch. |
|
I just submitted #3695 which is simpler, and in my opinion a better solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #3687. Just if it may be of inspiration.
It's so much very perfectible, but at least it doesn't even need modification of composer.json.
Note that Laravel 5.2 uses
services.phpinstead ofservices.json."- 3 chars" compliant. 💁
update: closing in favor of #3695.