-
Notifications
You must be signed in to change notification settings - Fork 24.4k
[5.1] Standalone "clear-compiled" script for use in Composer #3695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reminder: Laravel 5.2 uses |
Added a commit so that the script is compatible with both Laravel 5.1 and 5.2. |
Be kind to xdebug.scream and the like. On the contrary, if file deletion fails, SHOUT.
The idea is good but we probably want this file somewhere in the framework itself in case we have to change it mid release. Change this PR to just be the script change and then PR to laravel/framework with the script that deletes the files. |
Yeah but that's precisely what we can't do and is the source of the issues... |
Hmm, true. |
Should still be safe to do it on post update cmd since it doesn't load the whole app. |
@crynobone Yeh. It's fine to put this in laravel/framework, because we have no need to run commands before composer update. |
Yeah true we don't need to be doing anything pre-update anyways. So this can go into framework. |
👍 for doing it post-update/post-install with a simple script in laravel/framework |
But putting it in laravel/framework makes it hard to resolve |
I like this solution better than moving the command to the post-update-cmd |
So like this? laravel/framework#12827 |
Above is merged. Related: #3699 |
Alternative to #3694. Another way of solving #3687.
Ref: ClearCompiledCommand.php