Skip to content

[5.1] Standalone "clear-compiled" script for use in Composer #3695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

vlakoff
Copy link
Contributor

@vlakoff vlakoff commented Mar 19, 2016

Alternative to #3694. Another way of solving #3687.


Ref: ClearCompiledCommand.php

@vlakoff
Copy link
Contributor Author

vlakoff commented Mar 19, 2016

Reminder: Laravel 5.2 uses services.php instead of services.json.

@vlakoff
Copy link
Contributor Author

vlakoff commented Mar 19, 2016

Added a commit so that the script is compatible with both Laravel 5.1 and 5.2.
Less hassle for everybody. 😌

Be kind to xdebug.scream and the like.
On the contrary, if file deletion fails, SHOUT.
@taylorotwell
Copy link
Member

The idea is good but we probably want this file somewhere in the framework itself in case we have to change it mid release. Change this PR to just be the script change and then PR to laravel/framework with the script that deletes the files.

@vlakoff
Copy link
Contributor Author

vlakoff commented Mar 19, 2016

Yeah but that's precisely what we can't do and is the source of the issues...
vendor/laravel/framework may not be installed yet.

@taylorotwell
Copy link
Member

Hmm, true.

@crynobone
Copy link
Member

Should still be safe to do it on post update cmd since it doesn't load the whole app.

@GrahamCampbell
Copy link
Member

@crynobone Yeh. It's fine to put this in laravel/framework, because we have no need to run commands before composer update.

@taylorotwell
Copy link
Member

Yeah true we don't need to be doing anything pre-update anyways. So this can go into framework.

@barryvdh
Copy link
Contributor

👍 for doing it post-update/post-install with a simple script in laravel/framework

@vlakoff
Copy link
Contributor Author

vlakoff commented Mar 21, 2016

But putting it in laravel/framework makes it hard to resolve basePath, thus bootstrapPath.

@jmarcher
Copy link

I like this solution better than moving the command to the post-update-cmd

@barryvdh
Copy link
Contributor

So like this? laravel/framework#12827

@GrahamCampbell GrahamCampbell changed the title [5.1+] Standalone "clear-compiled" script for use in Composer [5.1] Standalone "clear-compiled" script for use in Composer Mar 23, 2016
@barryvdh
Copy link
Contributor

Above is merged. Related: #3699

@vlakoff vlakoff deleted the uptall-insdate-2 branch June 21, 2016 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants