-
Notifications
You must be signed in to change notification settings - Fork 24.4k
Remove pre-update-cmd #3687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pre-update-cmd #3687
Conversation
Can't rely on being able to run php artisan, before updating.
You should make the change to laravel/laravel 5.1 as well, let's not worsen the support nightmare that is coming. |
Running That is why i changed it in commit c334e47. |
Yes I know, but we can't rely on having a working install before..
But that would have the downside of not being able to change it. Or we could check if the autoload exists in the artisan file. If not, assume we're on a fresh install and just skip, without producing an error/stopping composer. |
Your suggestion for the check seems to be the best option. We can't rely on composer and the location of the files can change for instance I have |
Is this needed for Laravel 4.2? |
4.2 is not supported |
I just need to know if I need to apply this change to my 4.2 projects |
As people encountering the issue may land on this page, note an improved fix has been implemented since then. See laravel/framework#12827 and #3699. |
What about people with old 5.1 projects that they are checking out from source control, ie not installing Laravel from scratch? |
@omarjebari Well what i've found useful was first running |
The latest version which can be installed on command line, it still has the same problem. And "composer install --no-script" does not work on this version. How can I fix it? |
You should apply #3699 to your existing projects. |
I have viewed that, but I think I cannot fix the problem. I always use "composer create-project --prefer-dist laravel/laravel blog" to install laravel But now, it just show error. bootstrap/autoload.php on line 17 Please help me. |
I fixed it |
@ramseyjiang I got the same problem. What did you do with it? |
@ramseyjiang i have the same issue but i downloaded a project in my company and i'm trying to do composer install but display this http://stackoverflow.com/questions/39665219/why-does-composer-install-show-this-error-message what i should do? |
Can't rely on being able to run php artisan, before updating. See composer/composer#5066
When installing without lockfile, Composer now behaves as upgrade. It also executes the
pre-upgrade-cmd
instead ofpre-install-cmd
. Behaviour with composer.lock available is not changed.With the latest composer version, doing a fresh install will fail because the vendor files are not yet present.