-
Notifications
You must be signed in to change notification settings - Fork 24.4k
[5.2] Use ComposerScripts #3699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Use ComposerScripts to avoid loading any configuration/compiled files.
👍 |
I'm wondering if it would be safest to tag Laravel framework before merging this in case people clone this repo and then run composer install and get the current tagged version which doesn't have those changes? |
Yeah that's what I meant, a new laravel/framework tag (not laravel/laravel). |
Refs laravel/framework#12827 which is what this PR makes use of. |
I guess, now laravel/framework |
This works perfectly btw, updated my composer.json file :-) |
str_replace_array not support for array field , in helpers.php line 740 |
Above issue by reavenlin is unrelated, and I'm pretty sure is due to incorrect use of query builder. |
Use ComposerScripts to avoid loading any configuration/compiled files.
Should probably be done after a new (laravel/framework) version is tagged, to avoid problems with non-existing class..