Ignore .DS_Store #3926
Closed
Ignore .DS_Store #3926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It should be ignored in your global .gitignore as it is OS specific. See similar PR #3523 |
|
Well if we are going to include .idea in the .gitignore we might as well include this because i would say this might be as common as .idea. We should A. include it or B. stop including IDE/OS or ENV specific stuff in .gitignore. I know @taylorotwell included it (#3877) because he said he was tired of dealing with it. Maybe the better option is to remove it since global is the best place for this types of things. Then create a PR template that says DO NOT SUBMIT .gitignore file changes to PR. https://help.github.com/articles/creating-a-pull-request-template-for-your-repository/ |
|
.idea shouldn't be there either. It just got merged to shut people up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.