Skip to content

Update libgit2 to v1.2.0 #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 4, 2021

Conversation

jairbubbles
Copy link
Contributor

@jairbubbles jairbubbles commented Sep 3, 2021

@bording
Copy link
Member

bording commented Sep 4, 2021

As part of this PR, let's go ahead and update https://github.com/libgit2/libgit2sharp.nativebinaries/blob/master/build.libgit2.sh#L14 to be OpenSSL-Dynamic instead of OFF.

@jairbubbles
Copy link
Contributor Author

Sure I'll give it a shot!

@jairbubbles
Copy link
Contributor Author

I updated the value blindly, looks like it's all green!

@ethomson
Copy link
Member

ethomson commented Sep 4, 2021

I'm hopeful that this is a better outcome than the managed transport was. 🤞

@bording
Copy link
Member

bording commented Sep 4, 2021

I'm hopeful that this is a better outcome than the managed transport was. 🤞

@ethomson Would a similar approach for SSH support be possible? Being able to optionally support SSH and not need to worry about bundling libraries for it would be great.

@bording bording merged commit 8b862d4 into libgit2:master Sep 4, 2021
@bording
Copy link
Member

bording commented Sep 4, 2021

2.0.315-alpha.0.2 has been uploaded to nuget.org

@ethomson
Copy link
Member

ethomson commented Sep 4, 2021

Would a similar approach for SSH support be possible? Being able to optionally support SSH and not need to worry about bundling libraries for it would be great.

Possible, yes - but I don't have an estimate of the amount of work. I'm not super familiar with libssh2 or our use of it. I think that my big hesitation is that libssh2 doesn't appear to be a particular amazing library and hasn't seen many updates lately, IIRC. I worry that it would be a decent amount of effort for a disappointing result.

@bording
Copy link
Member

bording commented Sep 4, 2021

Would a similar approach for SSH support be possible? Being able to optionally support SSH and not need to worry about bundling libraries for it would be great.

Possible, yes - but I don't have an estimate of the amount of work. I'm not super familiar with libssh2 or our use of it. I think that my big hesitation is that libssh2 doesn't appear to be a particular amazing library and hasn't seen many updates lately, IIRC. I worry that it would be a decent amount of effort for a disappointing result.

That all makes sense. It was just something I was wondering about since it seems like the majority of the LibGit2Sharp forks and alternate NuGet packages on nuget.org are related to SSH support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants