-
Notifications
You must be signed in to change notification settings - Fork 67
Update libgit2 to v1.2.0 #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As part of this PR, let's go ahead and update https://github.com/libgit2/libgit2sharp.nativebinaries/blob/master/build.libgit2.sh#L14 to be |
Sure I'll give it a shot! |
I updated the value blindly, looks like it's all green! |
I'm hopeful that this is a better outcome than the managed transport was. 🤞 |
@ethomson Would a similar approach for SSH support be possible? Being able to optionally support SSH and not need to worry about bundling libraries for it would be great. |
2.0.315-alpha.0.2 has been uploaded to nuget.org |
Possible, yes - but I don't have an estimate of the amount of work. I'm not super familiar with libssh2 or our use of it. I think that my big hesitation is that libssh2 doesn't appear to be a particular amazing library and hasn't seen many updates lately, IIRC. I worry that it would be a decent amount of effort for a disappointing result. |
That all makes sense. It was just something I was wondering about since it seems like the majority of the LibGit2Sharp forks and alternate NuGet packages on nuget.org are related to SSH support. |
HTTPS
toOpenSSL-Dynamic