-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
[MNT]: _ImageBase.draw
and Axis.draw
args and kwargs
#27745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is internal API (it is called by the Aritsts parent as part of rendering the figure (the update methods in the GUIs and the No one should be calling this outside of the draw process so I don't think we need an deprecation period, but we should highlight it in the release notes (and be prepared to add a deprecation period if we actually broke somenone). |
Thanks for the explanation @tacaswell! I ended up here because I was looking at an artist in Cartopy whose |
If we want to be on the very safe side, we can still do a deprecation. There's no hurry in removing the arguments. |
Once you are down the path of writing your own |
Summary
The
draw
methods of _ImageBase and Axis take*args
and**kwargs
but do not do anything with them. The Ribbon Box example has an artist that inherits fromAxesImage
and also passes*args
and**kwargs
throughdraw
.Proposed fix
Based on #16022 my guess is that
*args
and**kwargs
should be removed from the signatures, though I don't know much about when and howdraw
gets called. If they should be removed, do we need a deprecation period?The text was updated successfully, but these errors were encountered: