Skip to content

2.2.x: install jquery_ui #14587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2019
Merged

2.2.x: install jquery_ui #14587

merged 1 commit into from
Jun 25, 2019

Conversation

jdemeyer
Copy link

PR Summary

Actually install vendored copy of jquery-ui. Fixes #14585.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jdemeyer jdemeyer force-pushed the install-jquery-ui branch from 564edad to d080ae2 Compare June 20, 2019 11:51
@jdemeyer jdemeyer changed the title Install jquery ui 2.2.x: install jquery_ui Jun 20, 2019
@anntzer anntzer added this to the v2.2.5 milestone Jun 20, 2019
@tacaswell
Copy link
Member

Thanks for tracking that down!

@tacaswell tacaswell mentioned this pull request Jun 21, 2019
Closed
timhoffm
timhoffm approved these changes Jun 25, 2019
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. CI failures likely due to #14590. @tacaswell can we merge as is or should this be rebased?

@jdemeyer jdemeyer force-pushed the install-jquery-ui branch from d080ae2 to 8da3569 Compare June 25, 2019 08:01
@dstansby dstansby merged commit bab36f5 into matplotlib:v2.2.x Jun 25, 2019
@jdemeyer jdemeyer mentioned this pull request Aug 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2.5
Development

Successfully merging this pull request may close these issues.
5 participants
@jdemeyer @tacaswell @timhoffm @anntzer @dstansby