Replace most jQuery with vanilla JavaScript #17053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
timhoffm
approved these changes
Apr 21, 2020
tacaswell
reviewed
Apr 24, 2020
tacaswell
reviewed
Apr 24, 2020
|
I went over this with @dorafc who signed off on the JS. Did local testing, something is broken with nabagg as closing the figure on the python side does not close the js side, but that is also broken on master. |
tacaswell
requested changes
Apr 24, 2020
|
The circle failure is due to the dateutil inventory not downloading and travis is due to a weird wx import error. |
|
Circle might be helped a bit by caching in #17183. |
This was done in ipympl, so is easier to compare if the same here.
This can be done with CSS selectors, so there's no need to add a class via JS. The hover effect seems to work without it anyway.
This is a mix of the change in ipympl, plus the same thing for our original version of other stuff. Fixes matplotlib#14596.
Otherwise the quotes get escaped during the templating process which results in invalid html/js being served.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This is a mix of the change in ipympl, plus the same thing for our original version of other stuff, using stuff like http://youmightnotneedjquery.com/ and this cheat sheet. Unfortunately, we can't just remove jQuery, because we have jquery-ui for the CSS and resizable handles. CSS is easy, and we can replace the handles without too much code (since we don't need its full flexibility), but this was large enough already.
Fixes #14596.
Waiting on the JS style fix PR.PR Checklist