Skip to content

FIX: Add get/set methods for 3D collections #18189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 24, 2020
Merged

FIX: Add get/set methods for 3D collections #18189

merged 7 commits into from
Sep 24, 2020

Conversation

tacaswell
Copy link
Member

@tacaswell tacaswell commented Aug 6, 2020 •
edited by QuLogic
Loading

closes #3370

We need to do an extra step to propagate the color information back to
the 3D projections

PR Summary

Replaces #5598, still needs tests.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

@tacaswell tacaswell added this to the v3.4.0 milestone Aug 6, 2020
@QuLogic QuLogic mentioned this pull request Sep 12, 2020
Draft
4 tasks
@QuLogic QuLogic force-pushed the fix_3370 branch 2 times, most recently from 5918750 to 68cec33 Compare September 17, 2020 03:52
This was linked to issues Sep 17, 2020
scatter - set_facecolors is not working on Axes3D #9725
Closed
Path3DCollection from 3D scatter cannot set_color #13035
Closed
@QuLogic QuLogic marked this pull request as ready for review September 17, 2020 07:11
@QuLogic QuLogic changed the title FIX: Add get/set color methods for some 3d collections FIX: Add get/set methods for 3D collections Sep 17, 2020
@QuLogic
Copy link
Member

QuLogic commented Sep 17, 2020

This now has tests, a what's new entry, and should have get/set for all the properties overridden in 3D collections.

@QuLogic QuLogic mentioned this pull request Sep 19, 2020
Merged
5 tasks
@tacaswell
Copy link
Member Author

I can't approve because I opened the PR from my fork, but plan to merge when it goes green.

Thank you for cleaning up work I started @QuLogic :)

@tacaswell tacaswell merged commit 073ea22 into matplotlib:master Sep 24, 2020
@tacaswell tacaswell deleted the fix_3370 branch September 24, 2020 00:48
@watermarkhu watermarkhu mentioned this pull request Sep 24, 2020
Open
@QuLogic QuLogic mentioned this pull request Oct 16, 2020
Closed
This was referenced Mar 24, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

Assignees
No one assigned
Labels
topic: mplot3d
Projects
None yet
Milestone
v3.4.0
5 participants
@tacaswell @QuLogic @dopplershift @dstansby @WeatherGod