Skip to content

Rename outdated seaborn styles. #22317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Rename outdated seaborn styles. #22317

merged 1 commit into from
Jan 26, 2022

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 25, 2022

They are kept available under a versioned name for backcompat.

See #20252, #8351, #13680.

attn @mwaskom, I guess.

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo adding a test that this actually warns (just for 1 name).

They are kept available under a versioned name for backcompat.
@anntzer
Copy link
Contributor Author

anntzer commented Jan 25, 2022

test added.

@mwaskom
Copy link

mwaskom commented Jan 25, 2022

LGTM, thanks @anntzer

@jklymak jklymak merged commit 5743492 into matplotlib:main Jan 26, 2022
@anntzer anntzer deleted the snsty branch January 26, 2022 08:27
@timhoffm
Copy link
Member

timhoffm commented Jan 26, 2022

Just wondering, would the spelling seaborn-0.8-bright be better than seaborn0.8-bright?

@tacaswell
Copy link
Member

I mildly prefer without the dash as the dash here is specifying something with in the namespace of seaborn styles and the 0.8 is clarifying that it is the namespace of a particular version of seaborn and we do not plan to pick up style sheets for every version of seaborn.

On the other hand, seaborn-0.8-bright does scan a bit better.

I also propose seaborn08 with no extra punctuation.

@QuLogic
Copy link
Member

QuLogic commented Jan 26, 2022

There is a vague convention in Fedora that compatibility packages be named <name><version> without other changes (and then subpackages would be <name><version>-<subpackage>), so I have a slight preference for that (i.e., seaborn0.8-bright, etc.)

@timhoffm
Copy link
Member

The python packaging naming convention is seaborn-0.8.tar.gz (https://pypi.org/project/seaborn/#files).

@QuLogic
Copy link
Member

QuLogic commented Jan 26, 2022

Those are not backwards-compatibility names though; those are <name>-<version>, whereas I mean <name><oldversion> as the name itself.

@timhoffm
Copy link
Member

I don't see (the point of) the distinction, but concerning package compatiblity I'm just a simple user 🤷.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants