-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Rename outdated seaborn styles. #22317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modulo adding a test that this actually warns (just for 1 name).
They are kept available under a versioned name for backcompat.
test added. |
LGTM, thanks @anntzer |
Just wondering, would the spelling |
I mildly prefer without the dash as the dash here is specifying something with in the namespace of seaborn styles and the 0.8 is clarifying that it is the namespace of a particular version of seaborn and we do not plan to pick up style sheets for every version of seaborn. On the other hand, I also propose |
There is a vague convention in Fedora that compatibility packages be named |
The python packaging naming convention is |
Those are not backwards-compatibility names though; those are |
I don't see (the point of) the distinction, but concerning package compatiblity I'm just a simple user 🤷. |
Changes in matplotlib style name, matplotlib/matplotlib#22317
They are kept available under a versioned name for backcompat.
See #20252, #8351, #13680.
attn @mwaskom, I guess.
PR Summary
PR Checklist
Tests and Styling
pytest
passes).flake8-docstrings
and runflake8 --docstring-convention=all
).Documentation
doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).