Bug Fix: Normalize kwargs for Histogram #29552
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
I believe this is the issue this would close? #28884 |
|
Good catch! I made this draft while writing the issue. I’ll update the info. |
|
You are right and that's ok. The issue itself is not decided whether we actually want plurals. This implements the obvious and uncontroversial part of the issue. |
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
|
Thanks @TheSkyentist! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
* Normalize kwargs for hist * Avoid shadowing the builtin first! Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
|
@meeseeksdev backport to v3.10.x |
…552-on-v3.10.x Backport PR #29552 on branch v3.10.x (Bug Fix: Normalize kwargs for Histogram)
PR summary
Closes #28884 by normalizing kwargs for hist. The behavior of shortened options, such as ls and ec, now behave as expected.
now produces test.pdf
First brought to my attention by @ecrohr
PR checklist