Skip to content

[EHN] Add tick rcparams #5158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 21 commits into from
Closed

[EHN] Add tick rcparams #5158

wants to merge 21 commits into from

Conversation

Tillsten
Copy link
Contributor

As per #5096

@@ -544,6 +544,11 @@ def __init__(self, fig, rect,
self._ycid = self.yaxis.callbacks.connect('units finalize',
self.relim)

self.tick_params(top=rcParams['ytick.top'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indentation looks wrong.

@Tillsten
Copy link
Contributor Author

Sorry not used my usual editor, which inserted tabs... oerks, should be fixed now.

@@ -214,6 +214,9 @@ axes3d.grid : True # display grid on 3d axes

### TICKS
# see http://matplotlib.org/api/axis_api.html#matplotlib.axis.Tick

xtick.left : True # draw ticks on the left side
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to line this up better

@WeatherGod
Copy link
Member

Needs a what's new. Is this going into 1.5? If so, one can just update that table I made.

@tacaswell
Copy link
Member

I think this should go in for 2.0 (adding rcparams to change the defaults is ok by me).

@tacaswell tacaswell added this to the next major release (2.0) milestone Sep 29, 2015
@Tillsten
Copy link
Contributor Author

Note that without the PR the new spline rcParams don't make too much sense. But they don't brake anything, so waiting for 2.0 is also ok.

@jenshnielsen
Copy link
Member

I would suggest including tests that demonstrates that these options actually work as intended

@Tillsten
Copy link
Contributor Author

Actually i can't find any other tests even testing the tick_params, so i don't have any idea where to place such a test.

@tacaswell
Copy link
Member

Should probably go in test_axes. These don't need to be image tests, just check if the artists report them selves as visible.

@Tillsten
Copy link
Contributor Author

Hmm, maybe move the rcParams usage to axis.set_tick_position where a default is taken?

@Tillsten
Copy link
Contributor Author

Does cleanup reset the rcParams? It does not seems so.

@Tillsten
Copy link
Contributor Author

Good idea to write the test, bottom/top belong to xtick and left/right to ytick....

@Tillsten
Copy link
Contributor Author

The test failure seems unrelated.

@jenshnielsen
Copy link
Member

@Tillsten Yes I think it is. I restarted the test

tacaswell and others added 8 commits November 4, 2015 22:58
Fix #347: Faster text rendering in Agg
MNT: Remove uses of font.get_charmap

Conflicts:
    lib/matplotlib/tests/test_font_manager.py

Conflicts with merging the tests, resloved to add only relavent code.
Merge pull request #5410 from mdboom/get-charmap-removal
Use a specific version of Freetype for testing
Use DejaVu fonts as default for text and mathtext
Don't draw text when it's completely clipped away
Merge pull request #5432 from mdboom/fix-segfault-in-text-drawing
@Tillsten
Copy link
Contributor Author

Tillsten commented Nov 8, 2015

@tacaswell I think this can go in now.

@mdboom
Copy link
Member

mdboom commented Nov 8, 2015

This should have a "What's New" entry.

@@ -1,4 +1,4 @@
"""
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BOM is added here as well.

Use DejaVu Sans as default fallback font
Merge pull request #5439 from mdboom/default-font-fix
@Tillsten
Copy link
Contributor Author

Tillsten commented Nov 9, 2015

Will do the whats new tomorrow.

@Tillsten
Copy link
Contributor Author

I have no idea how to remove the bom. I explictly resaved as utf-8, but it didnt help. :(

@mdboom
Copy link
Member

mdboom commented Nov 17, 2015

Closed by manually merging cbb3dc8 to remove BOM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants