-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
[EHN] Add tick rcparams #5158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EHN] Add tick rcparams #5158
Conversation
@@ -544,6 +544,11 @@ def __init__(self, fig, rect, | |||
self._ycid = self.yaxis.callbacks.connect('units finalize', | |||
self.relim) | |||
|
|||
self.tick_params(top=rcParams['ytick.top'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This indentation looks wrong.
Sorry not used my usual editor, which inserted tabs... oerks, should be fixed now. |
@@ -214,6 +214,9 @@ axes3d.grid : True # display grid on 3d axes | |||
|
|||
### TICKS | |||
# see http://matplotlib.org/api/axis_api.html#matplotlib.axis.Tick | |||
|
|||
xtick.left : True # draw ticks on the left side |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to line this up better
Needs a what's new. Is this going into 1.5? If so, one can just update that table I made. |
I think this should go in for 2.0 (adding rcparams to change the defaults is ok by me). |
Note that without the PR the new spline rcParams don't make too much sense. But they don't brake anything, so waiting for 2.0 is also ok. |
I would suggest including tests that demonstrates that these options actually work as intended |
Actually i can't find any other tests even testing the tick_params, so i don't have any idea where to place such a test. |
Should probably go in |
Hmm, maybe move the |
Does cleanup reset the rcParams? It does not seems so. |
Good idea to write the test, bottom/top belong to xtick and left/right to ytick.... |
The test failure seems unrelated. |
@Tillsten Yes I think it is. I restarted the test |
TST: drop py2.6 & py3.3 testing
MNT: Reduce number of font file handles opened
BUG: Dot should not be spaced when used as a decimal separator
ENH: Faster character mapping
CLN: Remove various Python 2.6 related workarounds
Fix #347: Faster text rendering in Agg
MNT: Remove uses of font.get_charmap Conflicts: lib/matplotlib/tests/test_font_manager.py Conflicts with merging the tests, resloved to add only relavent code.
Merge pull request #5410 from mdboom/get-charmap-removal
Use a specific version of Freetype for testing
Use DejaVu fonts as default for text and mathtext
Don't draw text when it's completely clipped away
Merge pull request #5432 from mdboom/fix-segfault-in-text-drawing
@tacaswell I think this can go in now. |
This should have a "What's New" entry. |
@@ -1,4 +1,4 @@ | |||
""" | |||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The BOM is added here as well.
Use DejaVu Sans as default fallback font
Merge pull request #5439 from mdboom/default-font-fix
Will do the whats new tomorrow. |
…ks are drawn. add whats new
I have no idea how to remove the bom. I explictly resaved as utf-8, but it didnt help. :( |
Closed by manually merging cbb3dc8 to remove BOM. |
As per #5096