Add test to colorbar.py to see if ax is an object as returned by plt.subplots #8733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed some debug statements and old comments; whitespace / line wrapping. In particular, debug comments which simply indicate that a function has been called can easily be replaced by tools such as https://pypi.python.org/pypi/hunter or https://pypi.python.org/pypi/smiley.
…n and turn into a list. This makes colorbar compaticble with the output of plt.subplots (for instance)
Parameterize test_fill_between and test_fill_betweenx
anntzer
reviewed
Jun 9, 2017
lib/matplotlib/colorbar.py
Outdated
| @@ -1118,6 +1118,8 @@ def make_axes(parents, location=None, orientation=None, fraction=0.15, | |||
| pad = kw.pop('pad', loc_settings['pad']) | |||
|
|
|||
| # turn parents into a list if it is not already | |||
| if isinstance(parents, np.ndarray): | |||
There was a problem hiding this comment.
I would replace this and the lines below by
parents = np.atleast_1d(parents).ravel().tolist()
(there will never be enough axes for this to be a performance issue...)
There was a problem hiding this comment.
Yes, that seems to work. Very clever!
DOC: Make histogram example figures fit on web page
DOC: removing sgskip on text path demo
Clarify how a FancyArrowPatch behaves
Allow divmod to be overridden by numpy
Various cleanups to backends code.
…n and turn into a list. This makes colorbar compaticble with the output of plt.subplots (for instance)
|
Sorry, my git skills screwed this up. I'll fix with a new pull request once I have it sorted out. My apologies. |
6 tasks
|
In desperate cases, you should be able to do something like (yes I know there are better ways to do this). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n and turn into a list. This makes colorbar compaticble with the output of plt.subplots (for instance)
PR Summary
fig.colorbar(pcm=pcm,ax=axs)can take a list of axes objects as the argument to ax. However,axs=plt.subplots(2,1)returns a numpyobject. This PR simply checks ifaxsis an object and flattens and makes the object a list. Now commands like:will take space away from all the subplots, and put a colorbar on the right of all four subplots.
PR Checklist