Skip to content

Fixes problems with line style and marker parameters in property cycle for axes.errorbars #9926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 691 commits into from

Conversation

as691454
Copy link
Contributor

@as691454 as691454 commented Dec 4, 2017

File axes/_axes.py modified from matplotlib 2.1.0 version fixing axes.errorbar to allow line styling from axes property cycle and fixing an exception axes.errorbars throws when marker face color is included int property cycle. Issues #9920 and #9922

_axes.zip

jklymak and others added 30 commits October 31, 2017 12:06
Further improve colormap discussion.
Remove unused global cmd_split variable.
Added an entry for mpl-scatter-density in the third-party tools page
Fix a few instances in the documentation where http(s):// git
URIs contained a colon rather than a slash to separate the host
from the path.

Using a colon is malformed, and results in an error (at least on
my git 2.13.3, perhaps other versions try harder to guess):

```
$ git clone https://github.com:matplotlib/matplotlib.git
Cloning into 'matplotlib'...
fatal: unable to access 'https://github.com:matplotlib/matplotlib.git/':
Port number ended with 'm'
```
The previous order was a bit of a mess.

I went for

    set_xfoo, get_xfoo, set_yfoo, get_yfoo

although

    set_xfoo, set_yfoo, get_xfoo, get_yfoo

would probably have worked equally well.
Correct https git URIs in documentation
The passed argument would be modified by function while it not designed to.
Convert dviread to use lru_cache.
BLD: Fix some bugs in `setupext.py`
Large width/height triggers a different code path that didn't correctly
draw limited arcs instead of the whole ellipse.

Fixes #9659.
Previously, if we had a pointer to an old timer when calling start(), we
would manually get the context for the old timer and from there get a
pointer to the attribute. The problem is that for a single-timer, the
timer is automatically invalidated (and context cleared) at the end.
This resulted in trying to Py_DECREF(0x0).

To fix this, use the built-in support for a callback to run when the
context is released. By doing so, we can also clean up a lot of code to
release the reference in stop() as well.
Simplifies things just a bit.
Group setting all attributes together. Use NULL (rather than 0) where
appropriate for clarity.
Fix arcs with very large width/height.
Fix spelling in coment
DOC: Update agg_oo_sgskip.py
dopplershift and others added 22 commits December 1, 2017 22:53
…xample

DOC: Updates multiprocessing example.
Modified rrulewraper to handle timezone-aware datetimes.
Deprecate unused ContourLabeler.get_real_label_width.
less_simple_linear_interpolation can be replaced by np.interp.
BLD: Switch to makefile-based doc build
Add context to where this method came from.
API: Deprecate Artist.onRemove, Artist.hitlist.
- Deprecate unused RendererAgg.debug variable.
- Passing debug=False to _RendererAgg has no effect (PyRendererAgg_init
  actually ignores kwds, and doesn't do anything with debug if it is
  passed positionally either).
- Moved a comment that was at the wrong line.
- Wrapped lines to 79 chars; removed allowance in pep8 checker.
Fix up some incorrect bits in Rectangle

Remember to update x1/y1 when setting x0/y0

Add methods to update x1/y1
Deprecate unused FigureManagerBase.show_popup.
(Avoids cluttering the source directory.)
In unit/memleak, write to in-memory buffer instead of file.
Unify (parametrize) test_composite across backends.
@jklymak
Copy link
Member

jklymak commented Dec 4, 2017

First, thanks so much for your PR! The more contributors the better!

But... You based this off 2.1.x, so it includes every change in master since 2.1.

  • Please make the pull request against master.
  • Please don't try to merge from your master. Make a branch first and ask to merge that. (i.e. git checkout -b my-new-fix)

http://matplotlib.org/devdocs/devel/contributing.html

When you do the merge there should only be one commit and one file changed ;-)

Its very much appreciated that doing this the first time is a bit of a learning curve. But if you can see it through it makes it very easy to contribute, and we very much need more people contributing!

Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in my comment, please PR off master from a new branch in your repository!

dopplershift and others added 4 commits December 4, 2017 15:10
Use left/right top/bottom instead of width/height in Rectangle
Use command keys for window shortcuts in Qt on OSX
@jklymak
Copy link
Member

jklymak commented Dec 5, 2017

I'm closing this because every time something is merged to master it get put in as a commit here. @as691454 when you get your commit against master please try again. If you have trouble feel free to ask here or on the gitter channel. Thanks again!

@jklymak jklymak closed this Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.