fix(lsp): Don't show clients with empty content in hover #33692
Conversation
9943e58 to
2f47401
Compare
8d06d0e to
abb3ee5
Compare
abb3ee5 to
e5cfea9
Compare
e5cfea9 to
eabf40c
Compare
runtime/lua/vim/lsp/buf.lua
Outdated
| results1[client_id] = result | ||
| local contents = result.contents | ||
| -- Ensure that there is some content to display | ||
| if type(contents) == 'string' or contents.kind or contents.language or contents[1] then |
There was a problem hiding this comment.
A comment explaining that this corresponds to checking that contents is a MarkedString | MarkedString[] | MarkupContent would be appreciated.
There was a problem hiding this comment.
I've simplified the check to just make sure #contents > 0 (i.e. it is not an empty table or an empty string)
good point. is this actually common, or is it a server quirk ? |
eabf40c to
313e543
Compare
I'm not sure if it's common, but anecdotally, both |
*Problem*: LSP clients that produced no diagnostic results are being shown in the diagnostics hover (e.g. the client name is shown with no results). *Solution*: This PR hides clients with no diagnostic content in the hover summary.
313e543 to
dc897b0
Compare
Problem:
LSP clients that produced no content are being shown in the hover summary (e.g. the client name is shown with no results).
Example of the problem - Typescript with multiple clients (
vtslsandgraphql) with empty section forgraphql:Another example where both servers have empty results:
Solution:
This PR hides clients with no content in the hover summary.