Skip to content

fix(chart): [chart] Fixed chart-core bug #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 2, 2024
Merged

fix(chart): [chart] Fixed chart-core bug #1708

merged 4 commits into from
Jul 2, 2024

Conversation

Davont
Copy link
Member

@Davont Davont commented Jul 2, 2024 •
edited by coderabbitai bot
Loading

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Bug Fixes

    • Improved data handling in chart-core to correctly format values when they are objects and not null.

  • Chores

    • Updated version of @opentiny/vue-chart-core from 3.17.0 to 3.17.1.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jul 2, 2024 •
edited
Loading

Walkthrough

This update to the Vue project's chart-core module focuses on enhancing the robustness and functionality of the getFormatted function by adding a null-check for values, updating the module's version to "3.17.1", and introducing a new utility import for cloneDeep. These changes improve handling of null values, ensure version clarity, and facilitate deep cloning operations.

Changes

File Change Summary
.../util.ts Modified getFormatted to include a null value check
.../package.json Updated version to "3.17.1"
.../chart-core.ts Added import for cloneDeep utility

Poem

In code's deep forest, a rabbit hopped with glee,
Null values tamed in functions, so formats run free.
With versions anew, updated to delight,
A cloneDeep import joins the code, shining bright.
Now charts will flourish, errors shall flee,
For the magic of code, as clear as can be.

Tip

Early access features: enabled

We are currently testing the following features in early access:

  • OpenAI gpt-4o model for code reviews and chat: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available.

Note:

  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
  • Please join our Discord Community to provide feedback and report issues.
  • OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jul 2, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Outside diff range and nitpick comments (7)
packages/vue/src/chart/chart-core/src/chart-core.ts (7)

Line range hint 248-252: Use optional chaining for cleaner code.

Replace the existing code with optional chaining to handle cases where properties might be undefined.

-  this.integrateChart && this.integrateChart.echartsIns && this.integrateChart.echartsIns.resize()
+  this.integrateChart?.echartsIns?.resize()

Line range hint 295-298: Use optional chaining for cleaner code.

Replace the existing code with optional chaining to handle cases where properties might be undefined.

-  this.integrateChart && this.integrateChart.echartsIns && this.integrateChart.echartsIns.resize()
+  this.integrateChart?.echartsIns?.resize()

Line range hint 492-492: Use optional chaining for cleaner code.

Replace the existing code with optional chaining to handle cases where properties might be undefined.

-  this.integrateChart && this.integrateChart.echartsIns && this.integrateChart.echartsIns.resize()
+  this.integrateChart?.echartsIns?.resize()

Line range hint 497-500: Use optional chaining for cleaner code.

Replace the existing code with optional chaining to handle cases where properties might be undefined.

-  this.integrateChart && this.integrateChart.echartsIns && this.integrateChart.echartsIns.resize()
+  this.integrateChart?.echartsIns?.resize()

Line range hint 538-540: Use optional chaining for cleaner code.

Replace the existing code with optional chaining to handle cases where properties might be undefined.

-  this.integrateChart && this.integrateChart.echartsIns && this.integrateChart.echartsIns.resize()
+  this.integrateChart?.echartsIns?.resize()

Line range hint 540-543: Use optional chaining for cleaner code.

Replace the existing code with optional chaining to handle cases where properties might be undefined.

-  this.integrateChart && this.integrateChart.echartsIns && this.integrateChart.echartsIns.resize()
+  this.integrateChart?.echartsIns?.resize()

Line range hint 548-548: Use optional chaining for cleaner code.

Replace the existing code with optional chaining to handle cases where properties might be undefined.

-  this.integrateChart && this.integrateChart.echartsIns && this.integrateChart.echartsIns.resize()
+  this.integrateChart?.echartsIns?.resize()
Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between fa7fa03 and 40488d6.

Files selected for processing (3)
  • packages/vue/src/chart/chart-core/common/util.ts (1 hunks)
  • packages/vue/src/chart/chart-core/package.json (1 hunks)
  • packages/vue/src/chart/chart-core/src/chart-core.ts (1 hunks)
Files skipped from review due to trivial changes (1)
  • packages/vue/src/chart/chart-core/package.json
Additional context used
Biome
packages/vue/src/chart/chart-core/common/util.ts

[error] 20-20: isNaN is unsafe. It attempts a type coercion. Use Number.isNaN instead.

See the MDN documentation for more details.
Unsafe fix: Use Number.isNaN instead.

(lint/suspicious/noGlobalIsNan)

[error] 32-32: isNaN is unsafe. It attempts a type coercion. Use Number.isNaN instead.

See the MDN documentation for more details.
Unsafe fix: Use Number.isNaN instead.

(lint/suspicious/noGlobalIsNan)

packages/vue/src/chart/chart-core/src/chart-core.ts

[error] 248-252: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

[error] 295-298: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

[error] 492-492: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

[error] 497-500: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

[error] 538-540: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

[error] 540-543: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

[error] 548-548: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

Additional comments not posted (2)
packages/vue/src/chart/chart-core/common/util.ts (1)

17-17: LGTM! The null check is correctly added.

The addition of !isNull(value) ensures that the function handles null objects correctly.

packages/vue/src/chart/chart-core/src/chart-core.ts (1)

8-8: LGTM! The import statement is correct.

The import of cloneDeep from ../base/util/cloneDeep aligns with its usage in the file.

@zzcr zzcr merged commit 80b0d28 into opentiny:release-3.17.0 Jul 2, 2024
kagol pushed a commit that referenced this pull request Jul 17, 2024
@zzcr @MomoPoppy
@gimmyhehe @shenjunjian @Davont @Huangyilin19
feat: sync release-3.17.0 to dev (#1748)
0b96166 
* fix(card): 修复card组件样式污染全局问题

* feat(drawer): [drawer] Add drag listening event (#1701)

* feat(drawer): [drawer] Add drag listening event

* feat(drawer): [drawer] Modify version number

* feat(vue): [button-group] add empty slot (#1700)

* feat(vue): [button-group] add empty slot

* docs(button-group): add new api version

* fix(select): fix Select‘s  SMB theme, multi select svg color (#1705)

* feat: update theme version

* fix(chart): [chart] Fixed chart-core bug (#1708)

* fix: chart-core添加cloneDeep引入

* fix: 修改chart组件getFormatted函数判断逻辑

* fix: 更新chart-core包版本为3.17.1

* fix(popper): fix build error in vitepress (#1711)

* fix(popper):  fix build error in vitepress

* fix(popper):  升级版本

* fix(select): rename select's css var name (#1713)

* fix(grid): [grid] change custom components to tinyvue components to a… (#1724)

* fix(grid): [grid] change custom components to tinyvue components to adapt difference theme

* Update package.json

* fix(drawer): fix the issue content can not display when using v-if (#1733)

* fix(dropdown): fix dropdown in virtual scrolling grid (#1717)

* feat: update renderless version

* fix(select): the input parameter of the computedDisabledTooltipcontent lost props (#1740)

* fix(select): the input parameter of the computedDisabledTooltipcontent does not contain props

* fix(select): update version

* fix(grid-toolbar): [grid] fix toolbar ref name error (#1745)

---------

Co-authored-by: MomoPoppy <125256456+MomoPoppy@users.noreply.github.com>
Co-authored-by: gimmyhehe <975402925@qq.com>
Co-authored-by: 申君健 <40288193@qq.com>
Co-authored-by: Davont <davontz@icloud.com>
Co-authored-by: Huang Yilin <huangyilin16@qq.com>
kagol pushed a commit that referenced this pull request Jul 31, 2024
@zzcr @MomoPoppy
@gimmyhehe @shenjunjian @Davont @Huangyilin19 @wuyiping0628
feat: sync release-3.17.0 to dev (#1801)
43f7971 
* fix(card): 修复card组件样式污染全局问题

* feat(drawer): [drawer] Add drag listening event (#1701)

* feat(drawer): [drawer] Add drag listening event

* feat(drawer): [drawer] Modify version number

* feat(vue): [button-group] add empty slot (#1700)

* feat(vue): [button-group] add empty slot

* docs(button-group): add new api version

* fix(select): fix Select‘s  SMB theme, multi select svg color (#1705)

* feat: update theme version

* fix(chart): [chart] Fixed chart-core bug (#1708)

* fix: chart-core添加cloneDeep引入

* fix: 修改chart组件getFormatted函数判断逻辑

* fix: 更新chart-core包版本为3.17.1

* fix(popper): fix build error in vitepress (#1711)

* fix(popper):  fix build error in vitepress

* fix(popper):  升级版本

* fix(select): rename select's css var name (#1713)

* fix(grid): [grid] change custom components to tinyvue components to a… (#1724)

* fix(grid): [grid] change custom components to tinyvue components to adapt difference theme

* Update package.json

* fix(drawer): fix the issue content can not display when using v-if (#1733)

* fix(dropdown): fix dropdown in virtual scrolling grid (#1717)

* feat: update renderless version

* fix(select): the input parameter of the computedDisabledTooltipcontent lost props (#1740)

* fix(select): the input parameter of the computedDisabledTooltipcontent does not contain props

* fix(select): update version

* fix(grid-toolbar): [grid] fix toolbar ref name error (#1745)

* fix(breadcrumb): [breadcrumb] resolve delimiter issued (#1755)

* fix(breadcrumb): [breadcrumb] resolve delimiter issued

* fix(breadcrumb): [breadcrumb] resolve delimiter issued

* feat: update runtime version

* fix(breadcrumb): [breadcrumb] resolve the issue of separator not switching (#1783)

* fix(theme): when release theme, copy dist to _dist and replace cssvar… (#1768)

* fix(theme): when release theme, copy dist to _dist and replace cssvar's prefix name

* fix(vue-theme): update package's version

---------

Co-authored-by: MomoPoppy <125256456+MomoPoppy@users.noreply.github.com>
Co-authored-by: gimmyhehe <975402925@qq.com>
Co-authored-by: 申君健 <40288193@qq.com>
Co-authored-by: Davont <davontz@icloud.com>
Co-authored-by: Huang Yilin <huangyilin16@qq.com>
Co-authored-by: wuyiping0628 <42107997+wuyiping0628@users.noreply.github.com>
kagol pushed a commit that referenced this pull request Aug 7, 2024
@Davont @kagol
fix(chart): [chart] Fixed chart-core bug (#1708)
c8ea17e 
* fix: chart-core添加cloneDeep引入

* fix: 修改chart组件getFormatted函数判断逻辑

* fix: 更新chart-core包版本为3.17.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@zzcr zzcr zzcr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Davont @zzcr