fix(breadcrumb): [breadcrumb] resolve delimiter issued #1755
Conversation
WalkthroughThe recent update introduces a change in the method of determining the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/renderless/src/breadcrumb-item/vue.ts (1 hunks)
Additional comments not posted (1)
packages/renderless/src/breadcrumb-item/vue.ts (1)
33-33: LGTM! But verify the usage ofbreadcrumb.separator.The change to prioritize
breadcrumb.separatoroverprops.separatoris approved. This ensures a more hierarchical approach to configuration.However, ensure that
breadcrumb.separatoris correctly set and used throughout the codebase.Verification successful
Verification Successful:
breadcrumb.separatoris correctly set and used throughout the codebase.The instances found in various files confirm that
breadcrumb.separatoris being utilized as expected. The hierarchical configuration approach is correctly implemented.
packages/renderless/src/breadcrumb-item/vue.tspackages/vue/src/breadcrumb-item/src/pc.vueexamples/sites/demos/pc/app/breadcrumb/separator.vueexamples/sites/demos/pc/app/breadcrumb/separator-composition-api.vueScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of `breadcrumb.separator` in the codebase. # Test: Search for the usage of `breadcrumb.separator`. Expect: Correct usage and assignment. rg --type python -A 5 $'breadcrumb.separator'Length of output: 75
Script:
#!/bin/bash # Description: Verify the usage of `breadcrumb.separator` in the codebase. # Test: Search for the usage of `breadcrumb.separator`. Expect: Correct usage and assignment. rg --type typescript -A 5 'breadcrumb.separator'Length of output: 83
Script:
#!/bin/bash # Description: Verify the usage of `breadcrumb.separator` in the codebase. # Test: Search for the usage of `breadcrumb.separator`. Expect: Correct usage and assignment. rg -t js -t ts -A 5 'breadcrumb.separator'Length of output: 3113
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/renderless/package.json (1 hunks)
Files skipped from review due to trivial changes (1)
- packages/renderless/package.json
* fix(breadcrumb): [breadcrumb] resolve delimiter issued * fix(breadcrumb): [breadcrumb] resolve delimiter issued
* fix(breadcrumb): [breadcrumb] resolve delimiter issued (#1755) * fix(breadcrumb): [breadcrumb] resolve delimiter issued * fix(breadcrumb): [breadcrumb] resolve delimiter issued * feat: update runtime version --------- Co-authored-by: wuyiping0628 <42107997+wuyiping0628@users.noreply.github.com> Co-authored-by: zzcr <894103554@qq.com>
* fix(card): 修复card组件样式污染全局问题 * feat(drawer): [drawer] Add drag listening event (#1701) * feat(drawer): [drawer] Add drag listening event * feat(drawer): [drawer] Modify version number * feat(vue): [button-group] add empty slot (#1700) * feat(vue): [button-group] add empty slot * docs(button-group): add new api version * fix(select): fix Select‘s SMB theme, multi select svg color (#1705) * feat: update theme version * fix(chart): [chart] Fixed chart-core bug (#1708) * fix: chart-core添加cloneDeep引入 * fix: 修改chart组件getFormatted函数判断逻辑 * fix: 更新chart-core包版本为3.17.1 * fix(popper): fix build error in vitepress (#1711) * fix(popper): fix build error in vitepress * fix(popper): 升级版本 * fix(select): rename select's css var name (#1713) * fix(grid): [grid] change custom components to tinyvue components to a… (#1724) * fix(grid): [grid] change custom components to tinyvue components to adapt difference theme * Update package.json * fix(drawer): fix the issue content can not display when using v-if (#1733) * fix(dropdown): fix dropdown in virtual scrolling grid (#1717) * feat: update renderless version * fix(select): the input parameter of the computedDisabledTooltipcontent lost props (#1740) * fix(select): the input parameter of the computedDisabledTooltipcontent does not contain props * fix(select): update version * fix(grid-toolbar): [grid] fix toolbar ref name error (#1745) * fix(breadcrumb): [breadcrumb] resolve delimiter issued (#1755) * fix(breadcrumb): [breadcrumb] resolve delimiter issued * fix(breadcrumb): [breadcrumb] resolve delimiter issued * feat: update runtime version * fix(breadcrumb): [breadcrumb] resolve the issue of separator not switching (#1783) * fix(theme): when release theme, copy dist to _dist and replace cssvar… (#1768) * fix(theme): when release theme, copy dist to _dist and replace cssvar's prefix name * fix(vue-theme): update package's version --------- Co-authored-by: MomoPoppy <125256456+MomoPoppy@users.noreply.github.com> Co-authored-by: gimmyhehe <975402925@qq.com> Co-authored-by: 申君健 <40288193@qq.com> Co-authored-by: Davont <davontz@icloud.com> Co-authored-by: Huang Yilin <huangyilin16@qq.com> Co-authored-by: wuyiping0628 <42107997+wuyiping0628@users.noreply.github.com>
* fix(breadcrumb): [breadcrumb] resolve delimiter issued * fix(breadcrumb): [breadcrumb] resolve delimiter issued
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
Bug Fixes
Chores
@opentiny/vue-renderlessto 3.17.5.