Skip to content

Conversation

kagol
Copy link
Member

@kagol kagol commented Jul 5, 2024

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Chores
    • Updated package version from 0.1.0 to 3.17.0 for fluent-editor.
    • Modified main and module entry points for better compatibility.
    • Revised paths for import and require statements.
    • Adjusted dependency version of "quill" for improved stability.

Copy link

coderabbitai bot commented Jul 5, 2024

Walkthrough

The recent update to packages/fluent-editor/package.json includes several modifications: the package version is bumped to 3.17.0, significant changes are made to the main and module entries to update the paths, and dependencies are refreshed, particularly "quill" which is now on version 2.0.0-dev.4. These alterations streamline module resolution and dependency management for better compatibility and performance.

Changes

File Change Summary
packages/fluent-editor/package.json Update version to 3.17.0, adjust main and module paths, and update "quill" dependency.

Poem

In the editor's realm, a new dawn breaks,
Paths have shifted, no mistake.
Version climbed up, dependencies too,
Quill's refined for something new.
Code Rabbit cheers with endless delight,
For smoother edits in the user's sight. 🌟🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kagol kagol added the bug Something isn't working label Jul 5, 2024
Copy link

github-actions bot commented Jul 5, 2024

[e2e-test-warn]
The component to be tested is missing.

The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug".

Please make sure you've read our contributing guide

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a037b97 and a98becc.

Files selected for processing (1)
  • packages/fluent-editor/package.json (2 hunks)
Additional comments not posted (5)
packages/fluent-editor/package.json (5)

3-3: Verify the justification for the significant version bump.

The version was incremented from "0.1.0" to "3.17.0". Ensure that this significant version bump is justified and documented, as it suggests major changes or improvements.


4-4: Verify the new main entry point.

The main entry point was changed to "dist/index.js". Ensure that this file exists and is correctly configured.


8-8: Verify the new module entry point.

The module entry point was updated to "dist/index.mjs". Ensure that this file exists and is correctly configured.


11-12: Verify the new import and require paths.

The paths for import and require were modified. Ensure that "dist/index.mjs" and "dist/index.js" exist and are correctly configured.


57-57: Verify the compatibility of the new dependency version.

The dependency version for "quill" was revised to "2.0.0-dev.4". Ensure that this version is compatible and does not introduce breaking changes.

@zzcr zzcr merged commit ed9b1a6 into dev Jul 7, 2024
@kagol kagol deleted the kagol/fix-fluent-editor branch July 26, 2024 09:28
kagol added a commit that referenced this pull request Aug 14, 2024
* fix(chart): [chart] Fixed chart-core bug (#1706)

* fix: 【Charts】update charts snapshots

* fix: 修复图表height为100%时的高度问题

* fix: 优化图表extend逻辑

* fix: 修复图表extend失效问题

* fix: 删除注释

* fix: 新增图表echartOption变量,以便用户获取echart配置

* fix: 修复playground百度地图案例错误问题

* fix: 修复图表option复杂变量失效问题

* fix: 修改高德百度地图案例注释

* fix: chart-core添加cloneDeep引入

* fix: 修改chart组件getFormatted函数判断逻辑

* fix: 更新chart-core包版本为3.17.1

* chore: release-3.17.0 to dev (#1720)

* fix(card): 修复card组件样式污染全局问题

* feat(drawer): [drawer] Add drag listening event (#1701)

* feat(drawer): [drawer] Add drag listening event

* feat(drawer): [drawer] Modify version number

* feat(vue): [button-group] add empty slot (#1700)

* feat(vue): [button-group] add empty slot

* docs(button-group): add new api version

* fix(select): fix Select‘s  SMB theme, multi select svg color (#1705)

* feat: update theme version

* fix(popper): fix build error in vitepress (#1711)

* fix(popper):  fix build error in vitepress

* fix(popper):  升级版本

* fix(select): rename select's css var name (#1713)

---------

Co-authored-by: zzcr <894103554@qq.com>
Co-authored-by: MomoPoppy <125256456+MomoPoppy@users.noreply.github.com>
Co-authored-by: gimmyhehe <975402925@qq.com>
Co-authored-by: 申君健 <40288193@qq.com>

* chore(fluent-editor): update package.json (#1721)

* feat: add virtual-scroll component

* feat(WIP):Add virtual-scroll component content

* feat(virtual-scroll):add virtual-scroll componet message

* Delete .vscode/tasks.json

* feat(virtual-scroll):add virtual-scroll basic component

* chore:delete unless cord

* chore:delete unless code

* chore:delete unless core

* chore:delete unless code

* chore:delete unless code

* chore:delete unless code

* chore:delete unless code

* chore:delete unless code

* fix(virtual-scroll):modify virtual scrolling problem

* chore:delete unless code

* chore:delete unless code

* feat(virtual-scroll):Add horizontal scrolling function

* feat(virtual-scroll):Added dynamic height function

* chore:Modify dynamic height bug

---------

Co-authored-by: Davont <davontz@icloud.com>
Co-authored-by: Kagol <kagol@sina.com>
Co-authored-by: zzcr <894103554@qq.com>
Co-authored-by: MomoPoppy <125256456+MomoPoppy@users.noreply.github.com>
Co-authored-by: gimmyhehe <975402925@qq.com>
Co-authored-by: 申君健 <40288193@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants