Skip to content

Unificate message for "clone method" return type error #3835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 13 commits into from
Closed

Unificate message for "clone method" return type error #3835

wants to merge 13 commits into from

Conversation

rjhdby
Copy link

@rjhdby rjhdby commented Feb 15, 2019

3 identical checks in one code block with uniformed messages

Constructor %s::%s() cannot be static
Destructor %s::%s() cannot be static
Clone method %s::%s() cannot be static
Constructor %s::%s() cannot declare a return type
Destructor %s::%s() cannot declare a return type

But for clone method

%s::%s() cannot declare a return type

without "Clone method" prefix

Громов Андрей Олегович added 13 commits January 27, 2019 18:14
Merge pull request #1 from php/master
49c7530 
zend_compile.c: zend_is_variable(). Removed unnecessary checks. Namin…
Merge branch 'master' of https://github.com/rjhdby/php-src
7c12baf
Merge pull request #2 from php/master
8ca90e7 
merge from head
Merge pull request #3 from php/master
2dfddff 
merge head
Merge pull request #4 from php/master
b95d3e9 
gmp_random() was removed
Merge pull request #5 from php/master
8e95535 
merge
Merge branch 'master' of https://github.com/php/php-src
466b342
Merge pull request #6 from php/master
f059d74 
merge
Merge branch 'master' of https://github.com/php/php-src
c245c5e
Merge branch 'master' of https://github.com/rjhdby/php-src
f2fd800
Clone method return type message
6b29b90
Merge branch 'master' of https://github.com/php/php-src
1f18155
Merge branch 'master' into clone_return_type_message
78470c9
carusogabriel
carusogabriel approved these changes Feb 15, 2019
View reviewed changes
Copy link
Contributor

@carusogabriel carusogabriel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this can go into PHP-7.4.

@cmb69
Copy link
Member

cmb69 commented Feb 15, 2019

Thanks! Applied to PHP-7.4 as d6a53ed.

@cmb69 cmb69 closed this Feb 15, 2019
@guilliamxavier
Copy link
Contributor

What about the equivalent in Zend/zend_API.c? BTW why are these checks duplicated in 2 files? (noticed in #4177)

@guilliamxavier guilliamxavier mentioned this pull request Apr 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carusogabriel carusogabriel carusogabriel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rjhdby @cmb69 @guilliamxavier @carusogabriel