Moves Python code out of interpreter file #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verhulstm
approved these changes
May 5, 2022
philippjfr
reviewed
May 5, 2022
pyscriptjs/src/pyscript.py
Outdated
| @@ -35,7 +37,7 @@ def identity(value, meta): | |||
| 'image/svg+xml': identity, | |||
| 'application/json': identity, | |||
| 'application/javascript': lambda value, meta: f'<script>{value}</script>' | |||
| } | |||
| } | |||
There was a problem hiding this comment.
It won't let me comment below but line 48 indentation is slightly off. Please fix before merging now that it's actually being used.
philippjfr
reviewed
May 5, 2022
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…script into fpliger/154_move_py_code_out
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #154, moving all the PyScript Python logic out of the interpreter.ts file and loading at runtime. Performance tests do not show any significant performance impacts.