Skip to content

Traducción library/keyword #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 24, 2020
Merged

Traducción library/keyword #1104

merged 4 commits into from
Oct 24, 2020

Conversation

fenriquegimenez-zz
Copy link
Contributor

Closes #856

narvmtz
narvmtz suggested changes Oct 24, 2020
View reviewed changes
Copy link
Contributor

@narvmtz narvmtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¡Muchas gracias @fenriquegimenez por la traducción!

Dejo un par de sugerencias, resolviéndolas y pasando los checks estaríamos cerca del merge 🎉

@fenriquegimenez-zz
Copy link
Contributor Author

Gracias por el review! Acabo de hacer un commit con las correcciones sugeridas. Saludos 👍🏽

cmaureir
cmaureir requested changes Oct 24, 2020
View reviewed changes
Copy link
Collaborator

@cmaureir cmaureir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

detalle y lo mergeamos

@fenriquegimenez-zz
Copy link
Contributor Author

Entendido, lo agregué como que me saltó en el pospell :)

@cmaureir
Copy link
Collaborator

Entendido, lo agregué como que me saltó en el pospell :)

porque de seguro no hiciste el paso anterior awk 1 dict dictionaries/*.txt > dict.txt no?
quizás si estás en windows...por eso no te va :( en ese caso hay que usar Git bash

@cmaureir cmaureir merged commit 9a6e9a6 into python:3.8 Oct 24, 2020
@cmaureir
Copy link
Collaborator

gracias @fenriquegimenez :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narvmtz narvmtz narvmtz requested changes

@cmaureir cmaureir cmaureir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translate 'library/keyword.po'
4 participants
@fenriquegimenez-zz @cmaureir @narvmtz @codesjedi