Skip to content

Upgrade Sphinx to 3.2.1 to match cpython #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Upgrade Sphinx to 3.2.1 to match cpython #1202

wants to merge 7 commits into from

Conversation

humitos
Copy link
Collaborator

@humitos humitos commented Jan 12, 2021

No description provided.

@humitos
Copy link
Collaborator Author

humitos commented Jan 12, 2021

Quiero ver si pasa el build en RTD. Es una prueba para ver si aparece el index.html. No estoy seguro que esté relacionado, pero también está bueno hacer el build nuestro con la misma versión que usan los de CPython y así evitar incompatibilidades.

@humitos
Copy link
Collaborator Author

humitos commented Jan 12, 2021

Bueno, el problema del index.html era otra cosa. Sin embargo creo que es bueno tener la version de Sphinx matcheando la que usa CPython para evitarnos dolores de cabeza.

Igualmente el GitHub Action no pasa por algún motivo que es muy tarde para mirar a la media noche :D

@cmaureir cmaureir added the enhancement New feature or request label Mar 20, 2021
@cmaureir cmaureir changed the base branch from 3.8 to 3.9 August 2, 2021 18:36
@cmaureir
Copy link
Collaborator

cmaureir commented Aug 3, 2021

buff ni idea, localmente la opción :undoc-members: evita los warnings que hacen que el build falle:

cpython/Doc/glossary.rst:140: WARNING: duplicate term description of awaitable, other instance in translation-memory
cpython/Doc/glossary.rst:226: WARNING: duplicate term description of context manager, other instance in translation-memory
cpython/Doc/glossary.rst:325: WARNING: duplicate term description of docstring, other instance in translation-memory
cpython/Doc/glossary.rst:655: WARNING: duplicate term description of keyword argument, other instance in translation-memory
cpython/Doc/glossary.rst:699: WARNING: duplicate term description of mapping, other instance in translation-memory
cpython/Doc/glossary.rst:1052: WARNING: duplicate term description of slice, other instance in translation-memory
cpython/Doc/glossary.rst:1066: WARNING: duplicate term description of statement, other instance in translation-memory
cpython/Doc/glossary.rst:1119: WARNING: duplicate term description of type hint, other instance in translation-memory

pero en el CI siguen saliendo :(

@cmaureir
Copy link
Collaborator

Esto ya se realizó como parte de la actualización a Python 3.10.0

@cmaureir cmaureir closed this Oct 18, 2021
@cmaureir cmaureir deleted the upgrade-sphinx branch December 10, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaureir cmaureir cmaureir approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@humitos @cmaureir