Skip to content

Traduccion extending/newtypes #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 25, 2020
Merged

Traduccion extending/newtypes #454

merged 5 commits into from
Jul 25, 2020

Conversation

cmaureir
Copy link
Collaborator

No description provided.

clacri
clacri reviewed Jul 20, 2020
View reviewed changes
Copy link
Contributor

@clacri clacri left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acabo de empezar la review, voy por el párrafo 20 solo porque tengo que ponerme en marcha con el trabajo de día :P igualmente, echale un vistazo al conflict del dict. Un abrazo!

Por cierto, esto cierra alguna issue? Por incluirlo en la descripción

@cmaureir
Copy link
Collaborator Author

Acabo de empezar la review, voy por el párrafo 20 solo porque tengo que ponerme en marcha con el trabajo de día :P igualmente, echale un vistazo al conflict del dict. Un abrazo!

Por cierto, esto cierra alguna issue? Por incluirlo en la descripción

no, casi todo lo de c-api y extending no es tan popular, así que por eso lo hice :D

clacri
clacri reviewed Jul 22, 2020
View reviewed changes
Copy link
Contributor

@clacri clacri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Voy por el párrafo 263 :)

clacri
clacri reviewed Jul 23, 2020
View reviewed changes
Copy link
Contributor

@clacri clacri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Voy por el 437 :)

clacri
clacri reviewed Jul 24, 2020
View reviewed changes
Copy link
Contributor

@clacri clacri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Voy por el 526 :)

@cmaureir
Copy link
Collaborator Author

Voy por el 526 :)

gracias :) He ido arreglando todas las cositas que has comentado.

gilgamezh
gilgamezh approved these changes Jul 25, 2020
View reviewed changes
Copy link
Collaborator

@gilgamezh gilgamezh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gilgamezh gilgamezh merged commit 4a6b980 into python:3.8 Jul 25, 2020
@cmaureir cmaureir deleted the traduccion-extending-newtypes branch July 25, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clacri clacri clacri left review comments

@gilgamezh gilgamezh gilgamezh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmaureir @gilgamezh @clacri