Skip to content

Conversation

SimonDamberg
Copy link
Contributor

@SimonDamberg SimonDamberg commented Oct 8, 2021

I have added Python version 3.10. I'm not quite sure how to update the badge in README, but if I understand it correctly it will update itself since it is automatically generated.

Closes #2713

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Added myself alphabetically to AUTHORS.rst (optional)

Bibo-Joshi and others added 27 commits October 3, 2021 20:12
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
Co-authored-by: Hinrich Mahler <22366557+Bibo-Joshi@users.noreply.github.com>
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
Signed-off-by: starry69 <starry369126@outlook.com>
Co-authored-by: Hinrich Mahler <22366557+Bibo-Joshi@users.noreply.github.com>
Co-authored-by: Hinrich Mahler <22366557+Bibo-Joshi@users.noreply.github.com>
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
Co-authored-by: poolitzer <25934244+Poolitzer@users.noreply.github.com>
@harshil21 harshil21 added this to the v14 milestone Oct 8, 2021
@harshil21 harshil21 added ⚙️ documentation affected functionality: documentation ⚙️ tests affected functionality: tests labels Oct 8, 2021
@Eldinnie
Copy link
Member

Eldinnie commented Oct 8, 2021

Hi Simon,

As you can see, the tests failed on python 3.10. Can you check why they failed by running the tests locally, and maybe fix the issues concerned?

@Bibo-Joshi
Copy link
Member

Hi. The py3.10 tests are failing due to something in the vendored urllib3. as we're going to drop that library anyway once we switch to asyncio (see #2352, this is the next big item on the todo list), it's probably not worth trying to work around this right now.
The changes that you made look good so far, so we can keep this PR open and merge later, when appropriate.

@Bibo-Joshi
Copy link
Member

superseded by #2968

@Bibo-Joshi Bibo-Joshi closed this Apr 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📋 do-not-merge-yet work status: do-not-merge-yet ⚙️ documentation affected functionality: documentation ⚙️ tests affected functionality: tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.