Skip to content

Fix for 3dsMax Python #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

dgsantana
Copy link
Contributor

Importing clr in 3dsMax python, causes the application to crash on
GetTypes from certain assemblies.

Importing clr in 3dsMax python, causes the application to crash on
GetTypes from certain assemblies.
@dgsantana
Copy link
Contributor Author

There should be some error checking on the domain assembly lookup, to avoid "exploding", when running in some embed python dcc (in this case 3dsmax). This is what this pull request does.

@tonyroberts
Copy link
Contributor

The travis and appveyor CI builds are failing with this error:

assemblymanager.cs(70,37): error CS1056: Unexpected character `$'

Could you refactor so as not to use C# 6 features please? (only a small change, and easier than converting the project to C# 6 for now)

thanks,
Tony

@dgsantana
Copy link
Contributor Author

Sure no problem.

A Qui, 7 de Jan de 2016, 09:21, Tony Roberts notifications@github.com
escreveu:

The travis and appveyor CI builds are failing with this error:

assemblymanager.cs(70,37): error CS1056: Unexpected character `$'

Could you refactor so as not to use C# 6 features please? (only a small
change, and easier than converting the project to C# 6 for now)

thanks,
Tony


Reply to this email directly or view it on GitHub
#114 (comment).

@dgsantana
Copy link
Contributor Author

Failing on AppVeyor py26, but not due to code changes.

@tonyroberts
Copy link
Contributor

Sorry, I didn't notice before but this pull request is against the master branch. All pull requests need to be against the develop branch (which is merged into master prior to a release).

@dgsantana
Copy link
Contributor Author

Ok, I will make one against the develop. Are you guys using simple git flow
workflow?

Tony Roberts notifications@github.com escreveu no dia quinta, 7/01/2016
às 19:47:

Sorry, I didn't notice before but this pull request is against the master
branch. all pull requests need to be agains the develop branch (which is
merged into master prior to a release).


Reply to this email directly or view it on GitHub
#114 (comment).

@tonyroberts
Copy link
Contributor

About as simple as it gets. The develop branch is for development; no problem accepting small commits directly on there, no need for a feature branch (although for more major features I would use a feature branch). Master is always buildable/releasable.

I'll move these commits to develop and create a new PR.

cheers,
Tony

@tonyroberts tonyroberts mentioned this pull request Jan 7, 2016
@tonyroberts
Copy link
Contributor

If I haven't screwed anything up your changes should now be in #115 :)

@dgsantana dgsantana closed this Jan 7, 2016
@dgsantana
Copy link
Contributor Author

Thanks ;).

Tony Roberts notifications@github.com escreveu no dia quinta, 7/01/2016
às 21:13:

If I haven't screwed anything up your changes should now be in #115
#115 :)


Reply to this email directly or view it on GitHub
#114 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants